Closed Bug 1506658 Opened Last year Closed 10 months ago

Ensure public API has appropriate nullability annotations

Categories

(GeckoView :: General, defect, P1)

defect

Tracking

(geckoview64 wontfix, geckoview65 wontfix, firefox-esr60 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
geckoview64 --- wontfix
geckoview65 --- wontfix
firefox-esr60 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: snorp, Assigned: Agi)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

That means all non-primitive arguments and return values need to have @Nullable or @NotNull.
We can probably do this together with https://github.com/mozilla-mobile/gradle-apilint/issues/2 with a generic "ensure that every API has an annotation in this set" lint.
Assignee: nobody → agi
A-C has asked for nullability annotations.
Priority: -- → P1
Depends on: 1506267
Priority: P1 → --
Sorry restoring flags :)
Priority: -- → P1
64=wontfix because this bug doesn't need to block Focus 8.0.
Upgrading apilint to the 0.1.6 release will also ensure that new APIs have
nullability annotations via the GV4 and GV5 lints, see [0].

[0]: https://github.com/mozilla-mobile/gradle-apilint/commit/b994c7ca9db056652ba4b5dd639437ddf2c5cc6f#diff-2c7de691a2642510f69b9ddf59276d85R569
Upgrading apilint to the 0.1.6 release will also ensure that new APIs have
nullability annotations via the GV4 and GV5 lints, see [0].

[0]: https://github.com/mozilla-mobile/gradle-apilint/commit/b994c7ca9db056652ba4b5dd639437ddf2c5cc6f#diff-2c7de691a2642510f69b9ddf59276d85R569
Attachment #9032524 - Attachment is obsolete: true
Attachment #9032251 - Attachment description: Bug 1506658 - Add @Nullable or @NonNull to all APIs. r?snorp!,rbarker!,esawin! → Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp!,rbarker!,esawin!
Attachment #9032251 - Attachment description: Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp!,rbarker!,esawin! → Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp!,rbarker!
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12616753519d
Add @Nullable or @NonNull to all APIs. r=snorp,rbarker,geckoview-reviewers
Product: Firefox for Android → GeckoView
https://hg.mozilla.org/mozilla-central/rev/12616753519d
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
65=wontfix because we don't need to uplift this lint check.
Target Milestone: Firefox 66 → mozilla66
You need to log in before you can comment on or make changes to this bug.