1506681 - Bounds-check autoAllocateChunkSize before using it

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Jason Orendorff [:jorendorff]]

Byte streams are disabled for now, so the autoAllocateChunkSize field is always `undefined`. So this bug report refers to code that is currently dead.

Scripts can provide an autoAllocateChunkSize value to the ReadableStream constructor, and the spec says the stream is supposed to allocate ArrayBuffers of that size. Our existing code for this does only the sanity-checking explicitly required by the spec: make sure the chunk size is a positive integer value. We should also check that the value is within the range that the ArrayBuffer constructor accepts (currently up to 2GB). Otherwise I think streams could be used to circumvent that limit.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1506681 - Add test for array buffer size limitations in BYOB Readable byte streams r?saschanaz

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

(Note: I think the responsibility for checking this lies in the ArrayBuffer constructor, so no streams specific changes are needed)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f26fa82e27c
Add test for array buffer size limitations in BYOB Readable byte streams r=saschanaz

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2f26fa82e27c