1506707 - Keep track of duplicate console messages in the client

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Currently, the devtools server keeps track of which messages have been sent to the client already, via isDuplicateReplayingMessage.  This causes problems when using a page without the console open, however.  The server will be active and send the messages to the client, which ignores them.  If the console is then opened, it will ask for all the messages sent up the current point, but the server won't send any of them because they have already been sent before.

I think the simplest solution here is to remove all filtering from the server, and have the client ignore duplicate messages when updating its Redux state, per the attached patch.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9024578 [details] [diff] [review]
patch

Review of attachment 9024578 [details] [diff] [review]:
-----------------------------------------------------------------

That looks like a nice solution, thanks Brian!
Do we already have a test to check that we don't show duplicate messages? If not, would it be hard to add one?

Comment 2

[Brian Hackett [Laid off!]]

(In reply to Nicolas Chevobbe from comment #1)
> Comment on attachment 9024578 [details] [diff] [review]
> patch
> 
> Review of attachment 9024578 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> That looks like a nice solution, thanks Brian!
> Do we already have a test to check that we don't show duplicate messages? If
> not, would it be hard to add one?

We don't, but I'll try to write one soon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d797322196
Keep track of duplicate console messages in the client, r=nchevobbe.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/45d797322196