1506709 - Enable accessibility caching by default

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

...disable full tree a11y by default.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1506709 - Disable Android full tree accessibility by default. r?snorp!

This would mean we would be using the cache exclusively unless otherwise
set. For now, the autofill tests are still set to use full tree a11y.
This is mostly because of kinks in how the test starts, as well as the
inputType that is not stored in the viewport cache. We should have a
followup bug to deal with that.

Comment 2

[Chris Peterson [:cpeterson]]

Based on bug 1499163 comment 26 and 27, it sounds like we'll want to uplift this fix to Fennec 64 Beta.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2814e983657b
Disable Android full tree accessibility by default. r=snorp

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2814e983657b

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 9024595 [details]
Bug 1506709 - Disable Android full tree accessibility by default. r?snorp!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1479037

User impact if declined: Users may potentially experience slowdowns if they have accessibility enabled (screen reader, password manager, etc)

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1501496, Bug 1479039, Bug 1507026, Bug 1506709, Bug 1502187, Bug 1507026, Bug 1505515

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): The risk here is moderate but notable.

String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9024595 [details]
Bug 1506709 - Disable Android full tree accessibility by default. r?snorp!

android a11y perf fix, approved for 64.0b12

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e1dcae0fe36

Comment 8

[Chris Peterson [:cpeterson]]

status-geckoview64=fixed