Closed Bug 1506721 Opened 6 years ago Closed 6 years ago

[BinAST] js -c attempts to execute BinAST inputs

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: acomminos, Assigned: efaust)

Details

Attachments

(3 files)

Attached file window-ref.binjs
When attempting to compile a BinAST-encoded file with `js -c`, a ReferenceError is thrown (as window is referenced). No error should be thrown here, as we're not supposed to actually run the code with the `-c` flag.

acomminos:/tmp$ js -c -f window-ref.js 
acomminos:/tmp$ js -c -B window-ref.binjs 
window-ref.binjs:ReferenceError: window is not defined
Stack:
  @window-ref.binjs:0:223
Attached file window-ref.js
Assignee: nobody → efaustbmo
Attached patch FixSplinter Review
Attachment #9024858 - Flags: review?(jorendorff)
Attachment #9024858 - Flags: review?(jorendorff) → review+
Pushed by efaustbmo@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f1d2f6c1e6e
Allow compile-only BinAST js shell invocations. (r=arai)
https://hg.mozilla.org/mozilla-central/rev/4f1d2f6c1e6e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: