1506739 - step out does not pause

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect, P1)

Description

[Jason Laster [:jlast]]

1. go to https://firefox-dev.tools/debugger-examples/examples/todomvc/
2. add a breakpoint in todo-view.js#32
3. step in 
4. step out

ER: pause on todo-view#33
AR: resume


the terminal shows several exceptions thrown so i assume something goes wrong in the server that prevents the debugger from pausing.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

This fixes a couple problems with stepping out:

- The parent frame's onStep handler is set directly, instead of using setReplayingOnStep as is required when replaying.

- The completion value from the popped frame is accessible to the stepping hook installed in the parent frame.  Since the completion value originates from when we were paused at the pop, we can't use it after resuming and stopping at a later location in the parent frame.  I don't know what this completion value is needed for, but if this is important we could fix this by allowing the debugger to e.g. directly fetch the completion value from the last popped frame.

Stepping is still kind of broken after this patch, though.  Stepping in and then out at the beginning of initialize() in todo-view.js works, but reverse stepping goes to the wrong place.  This looks like it is due to prematurely resuming in the ParentIPC.cpp logic referred to by bug 1505895 comment 5.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c840812bab2
Fix problems when stepping out of frames while replaying, r=jlast.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0c840812bab2