Closed Bug 1506761 Opened 10 months ago Closed 7 months ago

Vary the nursery free threshold based on nursery size

Categories

(Core :: JavaScript: GC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

Details

Attachments

(2 files)

It might be a good idea to vary this tunable.

https://searchfox.org/mozilla-central/source/js/src/gc/Scheduling.h#462

depending on nursery size.  Or maybe interpret it differently.
Blocks: 1433007
No longer depends on: 1433007
Assignee: nobody → pbone
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: --- → mozilla67

This makes more sense as a follow up for Bug 1433007 (or at the same time).

No longer blocks: 1433007
Depends on: 1433007
Depends on: 1526858

We collect the nursery in idle time if there is less than 256KB of space
remaining. However when the nursery is small this doesn't make sense, so
add a percentage-based threshold to be used when the nursery is small.

Depends on D20247

This is ready to land but I want to let telemetry settle after my last change.

Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df61ae31e2a8
Add a fraction threshold for collecting the nursery r=sfink
https://hg.mozilla.org/integration/autoland/rev/1a6bfb6eba8a
Fix existing spelling error r=sfink
Regressions: 1565631
You need to log in before you can comment on or make changes to this bug.