Closed Bug 1506774 Opened 2 years ago Closed 2 years ago

Consider discarding TypeScripts whenever we discard JIT code

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Bug 1506479 unified this so discarding TypeScripts now happens in Zone::discardJitCode, which means our preserve/release JIT code heuristics now also apply to TypeScript. I kept the JIT_SCRIPT_RELEASE_TYPES_PERIOD mechanism but removing this now would simplify the code and it would solve some GC-related issues I'm seeing with bug 1499644.

I'll get some perf data.
Bug 1506479 started unifying discarding of TypeScript and JIT code. This patch
removes the JIT_SCRIPT_RELEASE_TYPES_PERIOD heuristic so we now use the same
preserve-code heuristics for both.
I don't see any regressions on Try and I really like the simplicity of this, so I think it's worth trying.

(I now realize the commit message is not entirely correct, we don't release TypeScripts when we discard JIT code when we start sweeping for an incremental GC..)
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/34ee07ca08e9
Discard TypeScripts whenever we discard JIT code. r=jonco
https://hg.mozilla.org/mozilla-central/rev/34ee07ca08e9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.