Consider discarding TypeScripts whenever we discard JIT code

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
Bug 1506479 unified this so discarding TypeScripts now happens in Zone::discardJitCode, which means our preserve/release JIT code heuristics now also apply to TypeScript. I kept the JIT_SCRIPT_RELEASE_TYPES_PERIOD mechanism but removing this now would simplify the code and it would solve some GC-related issues I'm seeing with bug 1499644.

I'll get some perf data.
Assignee

Comment 1

7 months ago
Bug 1506479 started unifying discarding of TypeScript and JIT code. This patch
removes the JIT_SCRIPT_RELEASE_TYPES_PERIOD heuristic so we now use the same
preserve-code heuristics for both.
Assignee

Comment 2

7 months ago
I don't see any regressions on Try and I really like the simplicity of this, so I think it's worth trying.

(I now realize the commit message is not entirely correct, we don't release TypeScripts when we discard JIT code when we start sweeping for an incremental GC..)

Comment 3

7 months ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/34ee07ca08e9
Discard TypeScripts whenever we discard JIT code. r=jonco

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/34ee07ca08e9
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.