1506796 - Use OpenBrowserWindow() instead of window.open() to open new browser windows in marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[:Gijs (he/him)]

This should be a straightforward swap, in theory.

Comment 1

[:Gijs (he/him)]

Somehow I can never get this name right.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1506796 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo

Comment 3

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=903199ae0b1b4362dc0a2505195f0c42ff0aaf74

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2c153779804581dacefea76735fc7b96e6532fe

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Gijs! So this is only needed when opening a new browser window? Or do we also have to change `window.open()` for other shipped and/or custom chrome windows as what we use through our Marionette unit tests like in test_window_handles_chrome.py?

Comment 5

[:Gijs (he/him)]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> Thanks Gijs! So this is only needed when opening a new browser window? Or do
> we also have to change `window.open()` for other shipped and/or custom
> chrome windows as what we use through our Marionette unit tests like in
> test_window_handles_chrome.py?

Yeah, this needed updating throughout. As a bonus though, this patch now fixes bug 1335457. Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de2a17e1f61853fc202ba76fbd8bf9050a09b7df&searchStr=marionette

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to :Gijs (he/him) from comment #5)
> Yeah, this needed updating throughout. As a bonus though, this patch now
> fixes bug 1335457. Green try:

Fantastic! 

I just noticed that also Firefox puppeteer for Marionette uses `window.open()` for a new chrome window:
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/windows.py#353

I wonder why this doesn't cause a failure given that there are some tests like:
https://dxr.mozilla.org/mozilla-central/source/testing/firefox-ui/tests/puppeteer/test_windows.py#112

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6293789f6e9c
use OpenBrowserWindow instead of window.open() to create a browser window, r=whimboo

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6293789f6e9c