Closed Bug 1506796 Opened 5 years ago Closed 5 years ago

Use OpenBrowserWindow() instead of window.open() to open new browser windows in marionette

Categories

(Remote Protocol :: Marionette, enhancement)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1506796 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo
47 bytes, text/x-phabricator-request
Details | Review 
This should be a straightforward swap, in theory.
Somehow I can never get this name right.
Summary: Use BrowserOpenWindow() instead of window.open() to open new browser windows in marionette → Use OpenBrowserWindow() instead of window.open() to open new browser windows in marionette
Thanks Gijs! So this is only needed when opening a new browser window? Or do we also have to change `window.open()` for other shipped and/or custom chrome windows as what we use through our Marionette unit tests like in test_window_handles_chrome.py?
Attachment #9024675 - Attachment description: Bug 1506796 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo → Bug 1506797 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo
Attachment #9024675 - Attachment description: Bug 1506797 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo → Bug 1506796 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo
(In reply to Henrik Skupin (:whimboo) from comment #4)
> Thanks Gijs! So this is only needed when opening a new browser window? Or do
> we also have to change `window.open()` for other shipped and/or custom
> chrome windows as what we use through our Marionette unit tests like in
> test_window_handles_chrome.py?

Yeah, this needed updating throughout. As a bonus though, this patch now fixes bug 1335457. Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de2a17e1f61853fc202ba76fbd8bf9050a09b7df&searchStr=marionette
Blocks: 1335457
(In reply to :Gijs (he/him) from comment #5)
> Yeah, this needed updating throughout. As a bonus though, this patch now
> fixes bug 1335457. Green try:

Fantastic! 

I just noticed that also Firefox puppeteer for Marionette uses `window.open()` for a new chrome window:
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/windows.py#353

I wonder why this doesn't cause a failure given that there are some tests like:
https://dxr.mozilla.org/mozilla-central/source/testing/firefox-ui/tests/puppeteer/test_windows.py#112
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6293789f6e9c
use OpenBrowserWindow instead of window.open() to create a browser window, r=whimboo
https://hg.mozilla.org/mozilla-central/rev/6293789f6e9c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.