1506797 - XMLHttpRequest.abort() doesn't actually cancel the request

Status: RESOLVED INCOMPLETE

(Core :: DOM: Networking, defect, P3)

Description

[Khivar]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Making a XMLHttpRequest with a arraybuffer responseType in order to fetch a file. Then running XMLHttpRequest.abort().


Actual results:

Things that work when running abort() :

The readyState is changed to XMLHttpRequest.UNSENT (0)
The status code is set to 0.
The onabort event is dispatched correctly.

So it seems to work fine at first glance but in the background the request is still fetching the file. In the dev tools I can see the request still pending in the Network tab and it eventually completes with a HTTP 200 status code when the whole file has been fetched.


Expected results:

The request should not continue to fetch the file until completion in the background and the connection should close as soon as abort() is called.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1506797 - use OpenBrowserWindow instead of window.open() to create a browser window, r?whimboo

Comment 2

[Adrian Florinescu [:aflorinescu]]

I think this issue is the same as bug 1007109: abort() is not triggered, therefore duping after it.

Comment 3

[Khivar]

(In reply to Adrian Florinescu [:adrian_sv] from comment #2)
> I think this issue is the same as bug 1007109: abort() is not triggered,
> therefore duping after it.

Hello, as stated in my report, i call abort() manually and the abort event is correctly dispatched since XMLHttpRequest.onabort function is executed. So i don't think this is the same issue here.

Comment 4

[Adrian Florinescu [:aflorinescu]]

Fair point Zurldan, lets then reopen this issue and move it to its proper component for a better visibility. Could you please attach a reduced testcase in order to make sure everybody is on the same page?

Comment 5

[Honza Bambas (:mayhemer)]

Maybe the condition at [1] excludes calling Cancel() on the underlying channel.

[1] https://searchfox.org/mozilla-central/rev/f8de61826903996f6bdf41b11a2844dd59ac144f/dom/xhr/XMLHttpRequestMainThread.cpp#875-877

Comment 6

[Thomas Wisniewski [:twisniewski]]

Maybe the condition at [1] excludes calling Cancel() on the underlying channel.

No, it calls CloseRequest() (the next function in the link given), which calls mChannel->Cancel(NS_BINDING_ABORTED).

In fact, I can't reproduce this with a test-case like the following:

  const x = new XMLHttpRequest();
  x.responseType = "arraybuffer";
  x.open("get", "large_file.tar.bz2");
  x.send();
  setTimeout(function() {
    x.abort();
  }, 50);

The devtools only shows whatever size was downloaded before the abort, and things seem to be working fine otherwise.

If anyone has a working test-case or definitive steps to reproduce this, it would help.

Comment 7

[Krystof Beuermann]

I noticed this behavior today and created a CodeSandbox:
https://codesandbox.io/embed/jovial-cori-h14yg

For this to work you need to enable network speed throttling to e.g. "regular 3g".

Then you'll see the request is still fetching the file and returning http 200.

I've validated this with Chrome 75, where the request gets cancelled as it should be.

Screenshot:

Comment 8

[Krystof Beuermann]

https://i.ibb.co/596cM1b/Bildschirmfoto-2019-08-04-um-15-02-48.png

Comment 9

[astrom.flux]

I'm having this same problem in Firefox Developer Edition 70.0.1. I am unable to abort file uploads. I have not yet tried aborting other types of requests.

Comment 10

[Kershaw Chang [:kershaw]]

(In reply to Krystof Beuermann from comment #7)

I noticed this behavior today and created a CodeSandbox:
https://codesandbox.io/embed/jovial-cori-h14yg

For this to work you need to enable network speed throttling to e.g. "regular 3g".

Then you'll see the request is still fetching the file and returning http 200.

I've validated this with Chrome 75, where the request gets cancelled as it should be.

Screenshot:

FWIW, I can't reproduce with this test case.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

A needinfo is requested from the reporter, however, the reporter is inactive on Bugzilla. Given that the bug is still UNCONFIRMED, closing the bug as incomplete.

For more information, please visit BugBot documentation.