Implement document-domain featurePolicy

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

({dev-doc-complete})

Trunk
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [domsecurity-backlog1] [domsecurity-active])

Attachments

(1 attachment)

Assignee

Updated

7 months ago
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog1] [domsecurity-active]
Assignee

Comment 1

7 months ago
I don't want to write a WPT because it's already implemented here:

https://chromium-review.googlesource.com/c/chromium/src/+/1329791

Let me know if we want to send an intent-to-implement/ship email.
Attachment #9024780 - Flags: review?(ckerschb)
Attachment #9024780 - Flags: review?(annevk)

Comment 2

7 months ago
Comment on attachment 9024780 [details] [diff] [review]
document-domain.patch

Nit: in the standard this check is after the sandbox check. It doesn't matter now since it's the same exception, but if that ever changes it'd be observable. Doing this without intent to ship seems acceptable given how small and easy to remove it is if there are concerns.
Attachment #9024780 - Flags: review?(annevk) → review+
Comment on attachment 9024780 [details] [diff] [review]
document-domain.patch

Review of attachment 9024780 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks feasible to me - thanks!
Attachment #9024780 - Flags: review?(ckerschb) → review+

Comment 4

7 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e8db852399a
Implement document-domain feature policy, r=annevk, r=ckerschb

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e8db852399a
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Note to MDN writer's team:

IIRC, Feature-Policy is not enabled by default in any version of Firefox yet, so I'm not adding a note to the Fx65 rel notes about this. It could do with adding to the main Feature-Policy documentation however, if it is not there already.
Assignee

Comment 7

6 months ago
> IIRC, Feature-Policy is not enabled by default in any version of Firefox

It's enabled in nightly. But yes, I agree about not adding a note to the Fx65 rel.

document-domain reference docs exist already
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy#Directives
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy/document-domain

As you said, not shipping in Firefox, so compat table shows unsupported for now.

You need to log in before you can comment on or make changes to this bug.