Closed Bug 1506903 Opened 2 years ago Closed 2 years ago

Changes panel visible even when pref is off

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: rcaliman, Assigned: rcaliman)

References

Details

(Whiteboard: [good first verify])

Attachments

(1 file)

Bug 1506903 - Show Changes tab only when pref is on; r=pbro
47 bytes, text/x-phabricator-request
Details | Review 
STR:

- Go to about:config
- Flip this pref to FALSE:
devtools.inspector.changes.enabled
- Open a DevTools > Inspector

Expected:
Changes panel is not available

Actual:
Changes panel is visible.
Blocks: 1503925
The patch for Bug 1502857 accidentally removed the pref guard for the Changes panel. This patch reintroduces it.

This patch also addresses Bug 1503925 - Reposition Changes tab in Inspector sidebar to be right after Computed tab.
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22c78747446d
Show Changes tab only when pref is on; r=pbro
https://hg.mozilla.org/mozilla-central/rev/22c78747446d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Duplicate of this bug: 1503925
Whiteboard: [good first verify]

I have reproduced this bug with Nightly 65.0a1 (2018-11-13) (64-bit) on Windows 10. This bug's fix is verified with latest Beta 65.0b10

Build ID - 20190110221328
User Agent - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

[testday20190111]

You need to log in before you can comment on or make changes to this bug.