Find bar not readable with certain themes

VERIFIED FIXED in Firefox 67

Status

()

defect
P2
normal
VERIFIED FIXED
6 months ago
a month ago

People

(Reporter: bytesized, Assigned: ntim)

Tracking

(Depends on 1 bug, Regression, {regression})

Trunk
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 wontfix, firefox66 wontfix, firefox67 verified, firefox68 verified)

Details

Attachments

(2 attachments)

Posted image broken_find_bar.png
Nightly now seems to be coloring the Find bar (Control+F/Command+F) using some value that is provided by the active Firefox theme. I think that the way that the theme colors are being used here is not what the theme authors expected.

With the themes that I have tried, the Find bar does not seem to match the rest of the theme well. In some, it is completely unreadable.

The "Galaxy Blue" theme [1], for instance, seems to result in the bar's background and text color being the same. I am attaching a screenshot of this.
I have not noticed any other parts of Firefox that are similarly broken by this theme.

[1] https://addons.mozilla.org/en-US/firefox/addon/galaxy-blue/
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1505801
Oops, not a duplicate after all. Galaxy Blue sets both accentcolor and textcolor to white which obviously cannot work.

I'm not sure there's much we can or should do about this. Maybe we should sanity-check these colors when applying a theme.
Blocks: 1503304
Status: RESOLVED → REOPENED
Component: Theme → Themes
Product: Firefox → WebExtensions
Resolution: DUPLICATE → ---
See Also: → 1505801
Version: unspecified → Trunk
If you set both toolbar and textcolor to white, you'll get this. Perhaps we should just note this on https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme.
Assignee

Comment 4

6 months ago
I think part of the problem is that the tab line color follows the accent color, which encourages authors to make inaccessible themes. Can we make it follow the text color instead or some other text property instead ? 

(In reply to David Durst [:ddurst] (Regression Engineering Owner for 63) from comment #3)
> If you set both toolbar and textcolor to white, you'll get this. Perhaps we
> should just note this on
> https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/
> manifest.json/theme.

This sort of makes sense, this will intentionally set the background and text color to the same white color.
Flags: needinfo?(dao+bmo)
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #4)
> I think part of the problem is that the tab line color follows the accent
> color, which encourages authors to make inaccessible themes. Can we make it
> follow the text color instead or some other text property instead ?

Yeah, we can do that.
Flags: needinfo?(dao+bmo)
Assignee

Updated

6 months ago
See Also: → 1508081
Priority: -- → P2
Flags: needinfo?(lgreco)
Depends on: 1508081
See Also: 1508081

Happy to take a patch in nightly or even in beta 66 for this.
I'm marking it fix-optional to remove it from weekly triage.

Duplicate of this bug: 1525476
Assignee

Updated

3 months ago
Duplicate of this bug: 1530100
Depends on: 1530265
Depends on: 1530266

Comment 9

2 months ago

I checked the top 100 most popular themes on AMO and 27 are affected by this problem with a total of 98,000 users.

There are two separate regressions:

Comment 11

a month ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6ce615da7b68
Don't apply theme colors on findbar when theme has a header image. r=dao

Backed out changeset 6ce615da7b68 (Bug 1506913) for browser_ext_themes_findbar.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-7%2Cm-e10s%28bc7%29&fromchange=b1741ada6397acf01967eecc1e58b59e243d0de0&tochange=a5db25e4f47793fb613178d70cd47fed9391495e&selectedJob=239333009

Backout link: https://hg.mozilla.org/integration/autoland/rev/a5db25e4f47793fb613178d70cd47fed9391495e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239333009&repo=autoland&lineNumber=4268

[task 2019-04-10T14:07:07.181Z] 14:07:07 INFO - TEST-START | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js
[task 2019-04-10T14:07:07.491Z] 14:07:07 INFO - TEST-INFO | started process screentopng
[task 2019-04-10T14:07:08.113Z] 14:07:08 INFO - TEST-INFO | screentopng: exit 0
[task 2019-04-10T14:07:08.115Z] 14:07:08 INFO - Buffered messages logged at 14:07:07
[task 2019-04-10T14:07:08.116Z] 14:07:08 INFO - Entering test bound test_support_toolbar_properties_on_findbar
[task 2019-04-10T14:07:08.117Z] 14:07:08 INFO - Extension loaded
[task 2019-04-10T14:07:08.118Z] 14:07:08 INFO - Checking findbar background is set as toolbar color
[task 2019-04-10T14:07:08.119Z] 14:07:08 INFO - Buffered messages finished
[task 2019-04-10T14:07:08.121Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar background color should be the same as toolbar background color. - "rgb(242, 241, 240)" == "rgb(161, 64, 64)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_properties_on_findbar :: line 37
[task 2019-04-10T14:07:08.122Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.123Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_properties_on_findbar:37
[task 2019-04-10T14:07:08.124Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.124Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.126Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.127Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.128Z] 14:07:08 INFO - Checking findbar and button text color is set as toolbar text color
[task 2019-04-10T14:07:08.129Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.130Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar text color should be the same as toolbar text color. - "rgb(76, 76, 76)" == "rgb(148, 0, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_properties_on_findbar :: line 42
[task 2019-04-10T14:07:08.131Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.132Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_properties_on_findbar:42
[task 2019-04-10T14:07:08.133Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.134Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.135Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.135Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.137Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.138Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar button text color should be the same as toolbar text color. - "rgb(76, 76, 76)" == "rgb(148, 0, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_properties_on_findbar :: line 45
[task 2019-04-10T14:07:08.139Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.140Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_properties_on_findbar:45
[task 2019-04-10T14:07:08.141Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.142Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.143Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.143Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.145Z] 14:07:08 INFO - Leaving test bound test_support_toolbar_properties_on_findbar
[task 2019-04-10T14:07:08.154Z] 14:07:08 INFO - Entering test bound test_support_toolbar_field_properties_on_findbar
[task 2019-04-10T14:07:08.155Z] 14:07:08 INFO - Extension loaded
[task 2019-04-10T14:07:08.156Z] 14:07:08 INFO - Checking findbar textbox background is set as toolbar field background color
[task 2019-04-10T14:07:08.158Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.159Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar textbox background color should be the same as toolbar field color. - "rgb(255, 255, 255)" == "rgb(255, 0, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_field_properties_on_findbar :: line 89
[task 2019-04-10T14:07:08.160Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.161Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:89
[task 2019-04-10T14:07:08.162Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.163Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.164Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.164Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.165Z] 14:07:08 INFO - Checking findbar textbox color is set as toolbar field text color
[task 2019-04-10T14:07:08.166Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.167Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar textbox text color should be the same as toolbar field text color. - "rgb(60, 60, 60)" == "rgb(148, 0, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_field_properties_on_findbar :: line 94
[task 2019-04-10T14:07:08.168Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.169Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:94
[task 2019-04-10T14:07:08.170Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.171Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.172Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.173Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.174Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.175Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element left border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 72
[task 2019-04-10T14:07:08.176Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.177Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:72
[task 2019-04-10T14:07:08.178Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:97
[task 2019-04-10T14:07:08.179Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.180Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.181Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.182Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.183Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.184Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element right border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 75
[task 2019-04-10T14:07:08.185Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.186Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:75
[task 2019-04-10T14:07:08.187Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:97
[task 2019-04-10T14:07:08.188Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.189Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.190Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.191Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.192Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.193Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element top border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 78
[task 2019-04-10T14:07:08.195Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.196Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:78
[task 2019-04-10T14:07:08.198Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:97
[task 2019-04-10T14:07:08.200Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.201Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.203Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.207Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.208Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.210Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element bottom border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 81
[task 2019-04-10T14:07:08.212Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.213Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:81
[task 2019-04-10T14:07:08.215Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:97
[task 2019-04-10T14:07:08.217Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.218Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.220Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.221Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.223Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.224Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element left border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 72
[task 2019-04-10T14:07:08.227Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.228Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:72
[task 2019-04-10T14:07:08.229Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:98
[task 2019-04-10T14:07:08.229Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.230Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.231Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.231Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.232Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.233Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element right border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 75
[task 2019-04-10T14:07:08.234Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.235Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:75
[task 2019-04-10T14:07:08.236Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:98
[task 2019-04-10T14:07:08.236Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.237Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.238Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.239Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.243Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.244Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element top border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 78
[task 2019-04-10T14:07:08.244Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.245Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:78
[task 2019-04-10T14:07:08.246Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:98
[task 2019-04-10T14:07:08.247Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.248Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.249Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.250Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.251Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.252Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element bottom border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 81
[task 2019-04-10T14:07:08.252Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.253Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:81
[task 2019-04-10T14:07:08.254Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:98
[task 2019-04-10T14:07:08.255Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.255Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.256Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.257Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.259Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.259Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element left border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 72
[task 2019-04-10T14:07:08.260Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.261Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:72
[task 2019-04-10T14:07:08.261Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:99
[task 2019-04-10T14:07:08.262Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.263Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.264Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.264Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.265Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.266Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element right border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 75
[task 2019-04-10T14:07:08.267Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.268Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:75
[task 2019-04-10T14:07:08.268Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:99
[task 2019-04-10T14:07:08.269Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.270Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.271Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.271Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.272Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.273Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element top border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 78
[task 2019-04-10T14:07:08.274Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.275Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:78
[task 2019-04-10T14:07:08.276Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:99
[task 2019-04-10T14:07:08.276Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.277Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.278Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.279Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.279Z] 14:07:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T14:07:08.280Z] 14:07:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element bottom border color should be set. - "rgb(200, 197, 194)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 81
[task 2019-04-10T14:07:08.281Z] 14:07:08 INFO - Stack trace:
[task 2019-04-10T14:07:08.282Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:81
[task 2019-04-10T14:07:08.284Z] 14:07:08 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:99
[task 2019-04-10T14:07:08.288Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T14:07:08.289Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T14:07:08.291Z] 14:07:08 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T14:07:08.292Z] 14:07:08 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T14:07:08.309Z] 14:07:08 INFO - Leaving test bound test_support_toolbar_field_properties_on_findbar
[task 2019-04-10T14:07:08.327Z] 14:07:08 INFO - GECKO(3971) | MEMORY STAT | vsize 20974092MB | residentFast 1184MB
[task 2019-04-10T14:07:08.329Z] 14:07:08 INFO - TEST-OK | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | took 1144ms

Flags: needinfo?(ntim.bugs)
Assignee

Updated

a month ago
Flags: needinfo?(ntim.bugs)

Comment 13

a month ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f38ce082341e
Don't apply theme colors on findbar when theme has a header image. r=dao
Assignee

Updated

a month ago
Assignee: nobody → ntim.bugs

Backed out changeset f38ce082341e (Bug 1506913) for browser_ext_themes_findbar.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=68df166b4d9e53aaa1ff1e39ea6f3e534814f891&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-7%2Cm-e10s%28bc7%29&tochange=995276110de48270e38039380ce4674cad10d93e&selectedJob=239370607

Backout link: https://hg.mozilla.org/integration/autoland/rev/995276110de48270e38039380ce4674cad10d93e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239370607&repo=autoland&lineNumber=4246

[task 2019-04-10T16:15:51.966Z] 16:15:51 INFO - TEST-START | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js
[task 2019-04-10T16:15:52.305Z] 16:15:52 INFO - TEST-INFO | started process screentopng
[task 2019-04-10T16:15:52.937Z] 16:15:52 INFO - TEST-INFO | screentopng: exit 0
[task 2019-04-10T16:15:52.938Z] 16:15:52 INFO - Buffered messages logged at 16:15:51
[task 2019-04-10T16:15:52.939Z] 16:15:52 INFO - Entering test bound test_support_toolbar_properties_on_findbar
[task 2019-04-10T16:15:52.941Z] 16:15:52 INFO - Extension loaded
[task 2019-04-10T16:15:52.942Z] 16:15:52 INFO - Buffered messages logged at 16:15:52
[task 2019-04-10T16:15:52.943Z] 16:15:52 INFO - Checking findbar background is set as toolbar color
[task 2019-04-10T16:15:52.944Z] 16:15:52 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar background color should be the same as toolbar background color. - "rgb(161, 64, 64)" == "rgb(161, 64, 64)" -
[task 2019-04-10T16:15:52.944Z] 16:15:52 INFO - Checking findbar and button text color is set as toolbar text color
[task 2019-04-10T16:15:52.946Z] 16:15:52 INFO - Buffered messages finished
[task 2019-04-10T16:15:52.947Z] 16:15:52 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar text color should be the same as toolbar text color. - "rgb(76, 76, 76)" == "rgb(148, 0, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_properties_on_findbar :: line 36
[task 2019-04-10T16:15:52.948Z] 16:15:52 INFO - Stack trace:
[task 2019-04-10T16:15:52.949Z] 16:15:52 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_properties_on_findbar:36
[task 2019-04-10T16:15:52.950Z] 16:15:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T16:15:52.951Z] 16:15:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T16:15:52.952Z] 16:15:52 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T16:15:52.953Z] 16:15:52 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T16:15:52.953Z] 16:15:52 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-10T16:15:52.954Z] 16:15:52 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Findbar button text color should be the same as toolbar text color. - "rgb(76, 76, 76)" == "rgb(148, 0, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js :: test_support_toolbar_properties_on_findbar :: line 39
[task 2019-04-10T16:15:52.955Z] 16:15:52 INFO - Stack trace:
[task 2019-04-10T16:15:52.956Z] 16:15:52 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_properties_on_findbar:39
[task 2019-04-10T16:15:52.957Z] 16:15:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-10T16:15:52.958Z] 16:15:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-10T16:15:52.959Z] 16:15:52 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-10T16:15:52.960Z] 16:15:52 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-10T16:15:52.960Z] 16:15:52 INFO - Leaving test bound test_support_toolbar_properties_on_findbar
[task 2019-04-10T16:15:52.962Z] 16:15:52 INFO - Entering test bound test_support_toolbar_field_properties_on_findbar
[task 2019-04-10T16:15:52.963Z] 16:15:52 INFO - Extension loaded

Flags: needinfo?(ntim.bugs)
Assignee

Updated

a month ago
Flags: needinfo?(ntim.bugs)

Comment 15

a month ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/53c0f17ba52c
Don't apply theme colors on findbar when theme has a header image. r=dao

Comment 16

a month ago
bugherder
Status: REOPENED → RESOLVED
Last Resolved: 6 months agoa month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Duplicate of this bug: 1543534
Assignee

Updated

a month ago
No longer blocks: 1418605, 1503304
Regressed by: 1418605, 1503304
Assignee

Comment 18

a month ago

Comment on attachment 9054754 [details]
Bug 1506913 - Don't apply theme colors on findbar when theme has a header image. r=dao

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1503304
  • User impact if declined: See comment 0, impossible to use the findbar with certain themes
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: N/A
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS only
  • String changes made/needed: none
Attachment #9054754 - Flags: approval-mozilla-beta?
Assignee

Updated

a month ago
Flags: qe-verify?
Assignee

Updated

a month ago
Component: Themes → Themes
Product: WebExtensions → Toolkit

Tim, in the future please mark the flag qe-verify with '+' if QA manual testing is required to a specific bug.

QA Whiteboard: [qa-triaged]
Flags: qe-verify? → qe-verify+
Regressions: 1543936

Reproduced this issue on Win 10 x64 using 67.0b10.

Confirming the fix across platforms using latest Nightly, buildID 20190412093400.

Comment on attachment 9054754 [details]
Bug 1506913 - Don't apply theme colors on findbar when theme has a header image. r=dao

Low risk, CSS only with tests and verified by QA on nightly, uplift approved for 67 beta 11, thanks.

Attachment #9054754 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(lgreco)

Also confirming this is fixed on macOS 10.14 using Fx 67.0b11, buildID 20190415085659.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.