Closed Bug 1506940 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 14038 - Fixes and tweaks to wpt/css/filter-effects/

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14038 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14038
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:
>  Fixes and tweaks to wpt/css/filter-effects/
>  
>  filter-contrast-003.html
>  
>    Adjust the color from #400000 to #3f0000, since (0x40 / 255) is just
>    over 0.25 and can after filtering and rounding end up above 0.
>    (0x3f / 255) on the other hand is just below 0.25 and the result will
>    be clamped to zero.
>  
>  filter-external-001-test.html
>  filter-external-002-test.html
>  
>    Change the hue-rotate parameter in the external file from 120 to 150.
>    Move the file to support/ and remove lint entry.
>    Make both filters operate in sRGB to make computing the reference
>    easier. Use rgb(...) notation with percentage values in reference.
>  
>  fecolormatrix-type.html
>  
>    Add color-interpolation-filters=sRGB to the filter to make it easier
>    to reason about what the result should be. Use rgba(...) notation in
>    the ref using percentage notation.
>  
>  filters-test-brightness-003.html
>  
>    Add 'filter: brightness(0)' before 'filter: brightness()' to properly
>    test if the "no argument" notation is considered valid by the parser.
>  
>  filter-grayscale-001.html
>  filter-grayscale-002.html
>  filter-grayscale-003.html
>  filter-grayscale-004.html
>  filter-grayscale-005.html
>  
>    Remove the " (and not blue)" text from the reference and update the
>    001,004 and 005 tests accordingly.
>  
>  css-filters-animation-saturate.html
>  
>    Interpolate the argument from 4900% rather than 5000% to end at the
>    ref's 2500% (25).
>  
>  css-filters-animation-hue-rotate.html
>  
>    Sample the animation at .5 to match the expectation.
>  
>  css-filters-animation-drop-shadow.html
>  
>    Use explicit rgba(...) in the ref rather than the keyword 'gray'.
>    We're interpolating the color of the drop-shadow from 'black'
>    (rgba(0, 0, 0, 1)) to 'transparent' (rgba(0, 0, 0, 0)) here, so it's
>    better and more accurate to describe the color as "semi-transparent
>    black" (rgba(0, 0, 0, 0.5)).
>  
>  css-filters-animation-combined-001.html
>  
>    Initial value for animation for 'opacity(...)' is '1' - not zero.
>    Change test to interpolate from 0 -> 1 (rather than 1 -> 1)
>  
>  Bug: 903383
>  Change-Id: I4d0113989414616494b98c22fbac817f007cd762
>  Reviewed-on: https://chromium-review.googlesource.com/1333816
>  WPT-Export-Revision: faad1b57900b491da5e9c0b3aba25404eab16f5c
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 14 tests
PASS   : 7
FAIL   : 7

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/filter-effects/filters-test-brightness-003.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d16af01833d2
[wpt PR 14038] - Fixes and tweaks to wpt/css/filter-effects/, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c60d16c8fb3
[wpt PR 14038] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/d16af01833d2
https://hg.mozilla.org/mozilla-central/rev/9c60d16c8fb3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.