1506946 - Options window too small in 60.3.1 on Windows

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[WaltS48 [:walts48]]

Attachment: broken-options-window.PNG

While testing the Thunderbird 60.3.1 release candidate on Windows 10, clicking Tools > Options opened a reduced size window with only General to Attachments showing.

I couldn't resize the Window by grabbing a border or corner to get Calendar and Advanced to show.

Discussion on IRC suggested using the right arrow key to cycle to the hidden options which worked.

Tested with a new profile using 60.3.0 and the whole window shows with General to Advanced.

Updated that version to 60.3.1 and the Options window was again reduced in size.

The Options window should open with all tabs visible or be adjustable as needed.

Comment 1

[WaltS48 [:walts48]]

Attachment: 60_3_0-options_window.PNG

What it should look like.

Comment 2

[Jorg K (CEST = GMT+2)]

That's bad. I've been using "preferences in a tab" for a long time, so I don't ever see this window any more. So something that changed between 60.3 and 60.3.1?? If people can't open the options window, TB won't be so popular :-(

Comment 3

[Jorg K (CEST = GMT+2)]

The only thing we landed between those version which is vaguely related is bug 1504088.

Comment 4

[Wayne Mery (:wsmwk)]

Walt do you also see this on linux?

Comment 5

[Jorg K (CEST = GMT+2)]

It was never resizeable. Now it's just too small. I'll do a backout of bug 1504088 on ESR 60.

Comment 6

[Jorg K (CEST = GMT+2)]

You can't bisect ESR 60. I looked at everything that landed between 60.3 and 60.3.1 and there's only this CSS change.

Comment 7

[Jorg K (CEST = GMT+2)]

Backout of bug 1504088:
https://hg.mozilla.org/releases/comm-esr60/rev/c19a3e3679974a7251cd7a0626a3ff38b98b27db

Comment 8

[Jorg K (CEST = GMT+2)]

Fixed by backout.

Comment 9

[Jorg K (CEST = GMT+2)]

And I personally verified it with
https://queue.taskcluster.net/v1/task/ZX5KDbYIRJSqJHws1-wP9Q/runs/0/artifacts/public/build/install/sea/target.installer.exe

Comment 10

[WaltS48 [:walts48]]

(In reply to Wayne Mery (:wsmwk) from comment #4)
> Walt do you also see this on linux?

To some extent. Advanced is cutoff to read Advan, but the window can be resized and has Maximize, Minimize and Close buttons that work.

The window on Windows only has a close "X" in the top right corner.

Comment 11

[WaltS48 [:walts48]]

(In reply to Jorg K (GMT+1) from comment #2)
> That's bad. I've been using "preferences in a tab" for a long time, so I
> don't ever see this window any more. So something that changed between 60.3
> and 60.3.1?? If people can't open the options window, TB won't be so popular
> :-(

I also use "preferences in a tab" in my production profiles for release versions.

Now that it is the default in beta and nightly versions. Why not make it the default in 60.3.1 (build2 or 3) and leave bug 1504088 as fixed?

Comment 12

[Richard Marti (:Paenglab)]

:-( Sorry.

Removing the chromeclass-toolbar here: https://searchfox.org/comm-central/source/mail/components/preferences/aboutPreferences.xml#28 would also have fixed it without the issue in the other toolbars we have again.

Comment 13

[Jorg K (CEST = GMT+2)]

Sorry, I needed a quick fix. We can reland a proper fix in bug 1504088 later. Overlapping toolbars are not the end of the world, but not being to access all options *is*. Making "options in a tab" the default is also an option to consider, but we don't want to do that until we also have "accounts in a tab". It was forced onto us by Mozilla changes during the 62 cycle that made the stand-alone window unmaintainable, see bug 1465061 and friends.