1506962 - Try persisting chromemargin and brighttext attributes on browser windows

Status: NEW

(Firefox :: Tabbed Browser, enhancement, P5)

Description

[Mike Conley (:mconley) (:⚙️)]

With bug 1356920 fixed, browser-tabsintitlebar.js is simpler and we do our calculations for laying out the tabs in the titlebar in the actual layout and style engine of the browser, rather than in JS.

Because of this, I think we might be able to start taking advantage of the persist[1] attribute for XUL for the chromemargin and brighttext attributes, since I don't think these values tend to change very much from restart to restart. We can then maybe skip the ToolbarIconColor.inferFromText call in browser-tabsintitlebar when initializing the window, and only ever invalidate if we detect that the browser UI configuration is actually changing.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/persist

Comment 1

[:Gijs (out for now; he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)
> and only ever invalidate if we detect that the browser UI configuration is actually
> changing.

I worry that on Windows, this is more complex than one might expect because the OS configuration also affects the brighttext attribute...

Anyway, this seems worth doing if we can make it work, fxperf:p2.