1507001 - Outgoing attachments pane buttons disabled/enabled incorrectly

Status: RESOLVED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Geoff Lankow (:darktrojan)]

This is probably the result of being in the preferences tab instead of the preferences window. It uses a command controller which doesn't get registered in some circumstances. I'm going to remove that over-complication.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1507001-cloudfile-prefs-1.diff

With some bonus tidying-up that the linter doesn't catch.

Comment 2

[Geoff Lankow (:darktrojan)]

I've left the destroy method in because I'm about to use it again in a follow-up to bug 1481052.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9024885 [details] [diff] [review]
1507001-cloudfile-prefs-1.diff

Actually, that reminds me of another bug I should fix here. I'll get back to this.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1507001-cloudfile-prefs-2.diff

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9024936 [details] [diff] [review]
1507001-cloudfile-prefs-2.diff

Review of attachment 9024936 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks good. r=mkmelin
I was going to file a bug the other day about not being able to delete accounts where the auth expired. That's fixed with this patch.

::: mail/components/preferences/applications.js
@@ +837,5 @@
>        this.rebuildView();
>        this._settingsDeck.selectedPanel = this._defaultPanel;
>        delete this._accountCache[accountKey];
> +
> +      this._removeAccountButton.disabled = this._list.selectedCount == 0;

nit: (this._list.selectedCount == 0) 

... for better readability

Comment 6

[Jorg K (CEST = GMT+2)]

Actually, I have enough patches for now, so you can land this should there be a merge in the early GMT-AM hours.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e19bd82baf3c
Remove command controller from outgoing attachments pane. r=mkmelin