Closed Bug 1507001 Opened 2 years ago Closed 2 years ago

Outgoing attachments pane buttons disabled/enabled incorrectly

Categories

(Thunderbird :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file, 1 obsolete file)

This is probably the result of being in the preferences tab instead of the preferences window. It uses a command controller which doesn't get registered in some circumstances. I'm going to remove that over-complication.
Attached patch 1507001-cloudfile-prefs-1.diff (obsolete) — Splinter Review
With some bonus tidying-up that the linter doesn't catch.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9024885 - Flags: review?(mkmelin+mozilla)
I've left the destroy method in because I'm about to use it again in a follow-up to bug 1481052.
Comment on attachment 9024885 [details] [diff] [review]
1507001-cloudfile-prefs-1.diff

Actually, that reminds me of another bug I should fix here. I'll get back to this.
Attachment #9024885 - Attachment is obsolete: true
Attachment #9024885 - Flags: review?(mkmelin+mozilla)
Attachment #9024936 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9024936 [details] [diff] [review]
1507001-cloudfile-prefs-2.diff

Review of attachment 9024936 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks good. r=mkmelin
I was going to file a bug the other day about not being able to delete accounts where the auth expired. That's fixed with this patch.

::: mail/components/preferences/applications.js
@@ +837,5 @@
>        this.rebuildView();
>        this._settingsDeck.selectedPanel = this._defaultPanel;
>        delete this._accountCache[accountKey];
> +
> +      this._removeAccountButton.disabled = this._list.selectedCount == 0;

nit: (this._list.selectedCount == 0) 

... for better readability
Attachment #9024936 - Flags: review?(mkmelin+mozilla) → review+
Actually, I have enough patches for now, so you can land this should there be a merge in the early GMT-AM hours.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e19bd82baf3c
Remove command controller from outgoing attachments pane. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.