Closed Bug 1507026 Opened 6 years ago Closed 6 years ago

ConcurrentModificationException when accessing accessible node cache

Categories

(GeckoView :: General, defect, P1)

Product:
GeckoView
Component:
General
Type:
defect

Tracking

(geckoview64 fixed, firefox63 unaffected, firefox64 fixed, firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
geckoview64 --- fixed
firefox63 --- unaffected
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

Bug 1507026 - Correctly synchronize a11y cache access. r?snorp!
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review 
Looks like I didn't use Java's synchronized blocks correctly. I was using the method modifier, and it does not work with a mix of inner classes.
Blocks: 1506709
Based on bug 1499163 comment 26 and 27, it sounds like we'll want to uplift this fix to Fennec 64 Beta.
status-firefox63: --- → unaffected
status-firefox64: --- → affected
status-firefox65: --- → affected
Priority: -- → P1
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b394452b9a9
Correctly synchronize a11y cache access. r=snorp
https://hg.mozilla.org/mozilla-central/rev/3b394452b9a9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment on attachment 9024897 [details]
Bug 1507026 - Correctly synchronize a11y cache access. r?snorp!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1479037

User impact if declined: Potential crashes when caching is enabled.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1501496, Bug 1479039, Bug 1507026, Bug 1506709, Bug 1502187, Bug 1506709, Bug 1505515

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): 

String changes made/needed:
Attachment #9024897 - Flags: approval-mozilla-beta?
Comment on attachment 9024897 [details]
Bug 1507026 - Correctly synchronize a11y cache access. r?snorp!

android a11y fix, approved for 64.0b12
Attachment #9024897 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-geckoview64=fixed
status-geckoview64: --- → fixed
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: