1507028 - [wpt-sync] Sync PR 14042 - Fix background image painting of very small images

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14042 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14042
Details from upstream follow.

Stephen Chenney <[e-mail]> wrote:
>  Fix background image painting of very small images
>  
>  The background image fast path painting rounds the image src rect
>  to integer sizes assuming sprite maps and/or reasonably large images.
>  When a very small image is used scaled up to a large size (such as
>  constant color images scaled up to form progress bars by animating
>  background size) the src rect may be 1 x [small number] which gets
>  rounded to zero size.
>  
>  This patch changes the code to detect this situation and not round
>  in such cases.
>  
>  It's worth recording that an alternate approach is to detect when
>  the rounding results in a significant change in src rect and always
>  switch to unrounded in that case. But it would be more expensive for
>  a relatively uncommon case.
>  
>  R=fmalita
>  BUG=904042
>  
>  Change-Id: I24657a5d087c0dda0fd8a5e3c3d08e1e4eb02473
>  Reviewed-on: https://chromium-review.googlesource.com/1334291
>  WPT-Export-Revision: f2feb6db0fa5917e01224067f6199618c97be1c4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=919cbcee4fc00ce6e544caf5bb6d95426752e977

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=829a08ac5f33ec5f8d6baa515580aec7917b14de

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3fc5e4926cfe13666312b44c62fa81be6ee4500

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests
PASS   : 1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf0908137df
[wpt PR 14042] - Fix background image painting of very small images, a=testonly

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2cf0908137df