1507049 - Rename MOZ_CrashOOL and associated macro

Status: RESOLVED FIXED

(Core :: MFBT, defect, P3)

Description

[Mike Hommey [:glandium]]

Bug 1496503 moved MOZ_CrashOOL to Assertions.h and made it inline, which makes the "OOL" part weird.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1507049 - Rename MOZ_CrashOOL MOZ_Crash. r?froydnj

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1507049 - Rename GeckoCrashOOL GeckoCrash. r?froydnj

Depends on D18513

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1507049 - Rename MOZ_CRASH_UNSAFE_OOL MOZ_CRASH_UNSAFE. r?froydnj

Depends on D18514

Comment 4

[Chris Peterson [:cpeterson]]

Mostly green Try test run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=12f61c1854cb7b9e460abe67355b243b2b37fdef&selectedJob=225724322

Comment 5

[Chris Peterson [:cpeterson]]

Nathan, should I add the new MOZ_Crash and GeckoCrash function names to Socorro's crash signature skip list? Neither MOZ_CrashOOL nor GeckoCrashOOL are on the signature skip list, but MOZ_Crash is already on Socorro's signature skip list (add in bug 733235). Here's a search for recent crashes with *CrashOOL* in the signature:

https://crash-stats.mozilla.com/search/?signature=~CrashOOL

Should I retroactively add MOZ_CrashOOL nor GeckoCrashOOL to the signature skip list for crash reports from Firefox versions < 67?

Also, looking at a typical Rust panic (crash report bp-70f7c1da-90a5-409c-8b9b-63bac0181116 for WebRender bug 1507705), should we skip the following Rust function names, too?

gkrust_shared::panic_hook
core::ops::function::Fn::call
rust_begin_unwind

The skip list already includes core::panicking::* and std::panicking::*, but that doesn't help if the interesting function names in the stack trace are still preceded by generic crash handler functions like gkrust_shared::panic_hook.

Comment 6

[Nathan Froyd [:froydnj]]

I think all those additions to the skip list would be reasonable. Bonus points if you add them to the skip list prior to landing the relevant patches.

Comment 7

[Chris Peterson [:cpeterson]]

Looks like some of the Rust panic function names were recently added to the skip lists by bug 1514746. In that case, I will just land these changes to rename MOZ_CrashOOL and GeckoCrashOOL.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70d80c4a3fa0
Rename MOZ_CrashOOL MOZ_Crash. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/426f2e129858
Rename GeckoCrashOOL GeckoCrash. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e9ceabc7541
Rename MOZ_CRASH_UNSAFE_OOL MOZ_CRASH_UNSAFE. r=froydnj

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/70d80c4a3fa0
https://hg.mozilla.org/mozilla-central/rev/426f2e129858
https://hg.mozilla.org/mozilla-central/rev/7e9ceabc7541