Closed Bug 1507049 Opened Last year Closed 9 months ago

Rename MOZ_CrashOOL and associated macro

Categories

(Core :: MFBT, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: glandium, Assigned: cpeterson)

References

Details

Attachments

(3 files)

Bug 1496503 moved MOZ_CrashOOL to Assertions.h and made it inline, which makes the "OOL" part weird.
Assignee: nobody → cpeterson
Blocks: 1496503
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
See Also: → 733235

Nathan, should I add the new MOZ_Crash and GeckoCrash function names to Socorro's crash signature skip list? Neither MOZ_CrashOOL nor GeckoCrashOOL are on the signature skip list, but MOZ_Crash is already on Socorro's signature skip list (add in bug 733235). Here's a search for recent crashes with *CrashOOL* in the signature:

https://crash-stats.mozilla.com/search/?signature=~CrashOOL

Should I retroactively add MOZ_CrashOOL nor GeckoCrashOOL to the signature skip list for crash reports from Firefox versions < 67?

Also, looking at a typical Rust panic (crash report bp-70f7c1da-90a5-409c-8b9b-63bac0181116 for WebRender bug 1507705), should we skip the following Rust function names, too?

gkrust_shared::panic_hook
core::ops::function::Fn::call
rust_begin_unwind

The skip list already includes core::panicking::* and std::panicking::*, but that doesn't help if the interesting function names in the stack trace are still preceded by generic crash handler functions like gkrust_shared::panic_hook.

Flags: needinfo?(nfroyd)

I think all those additions to the skip list would be reasonable. Bonus points if you add them to the skip list prior to landing the relevant patches.

Flags: needinfo?(nfroyd)

Looks like some of the Rust panic function names were recently added to the skip lists by bug 1514746. In that case, I will just land these changes to rename MOZ_CrashOOL and GeckoCrashOOL.

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70d80c4a3fa0
Rename MOZ_CrashOOL MOZ_Crash. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/426f2e129858
Rename GeckoCrashOOL GeckoCrash. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e9ceabc7541
Rename MOZ_CRASH_UNSAFE_OOL MOZ_CRASH_UNSAFE. r=froydnj
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.