Closed Bug 1507051 Opened 11 months ago Closed 11 months ago

replace libyuv's README_MOZILLA with moz.yaml

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: glob, Assigned: glob)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

we're standardising how vendored code is annotated; libyuv's README_MOZILLA should be replaced with a moz.yaml file.
jya,

after running libyuv's `update.py` script pulling from the current commit `98a0a157dcf5dee0882b2dfcc9578ab1f44afb12` i'm seeing these unexpected differences in my local repo.

is the best course of action here to create a new patch file which reverts these changes as part of the `update.py` process?
Attachment #9024919 - Flags: feedback?(jyavenard)
note to self: update.py should copy `libyuv/libyuv/LICENSE` to `libyuv/LICENSE`
Depends on: moz.yaml
IIUC, libyuv has been mostly maintained by :jesup and may have diverged from upstream. Those changes seems to be MSVC related. I don't know how relevant they still are today.
Flags: needinfo?(rjesup)
Comment on attachment 9024919 [details] [diff] [review]
libyuv-after-noop-update.patch

Review of attachment 9024919 [details] [diff] [review]:
-----------------------------------------------------------------

that change was done in bug 1491848, and according to the commit log, it was a cherry-pick from upstream. so likely okay to drop and re-add
Attachment #9024919 - Flags: feedback?(jyavenard) → feedback+
Flags: needinfo?(rjesup)
(In reply to Jean-Yves Avenard [:jya] from comment #4)
> that change was done in bug 1491848, and according to the commit log, it was
> a cherry-pick from upstream. so likely okay to drop and re-add

ah, thanks for digging that up.  looks like i'll have to create a new patch file for bug 1491848 to keep those changes post update.  i'll what for jesup to confirm before proceeding.
Since bug 1491848 was a cherrypick from upstream, is that not included in the fresh import?

Note that with non-"released" upstreams, best practice is to use a rev that was vendored (rolled) into Chrome (or whatever) when possible, since presumably that gets at least indirectly tested that way.  One can also take the tip (especially of fairly quiet upstream projects) if we're pretty certain it's safe to do so.
Aha.  Bug 1491848 should have added it's changes to the list of .patch files to apply on update.  (and if they're cherrypicks, we'd remove the .patch on update when they become obsolete)
Replace README_MOZILLA with moz.yaml, various fixups for update.py, and create
a missing patch file from Bug 1491848.
Priority: -- → P3
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ee93495fe0c
replace libyuv's README_MOZILLA with moz.yaml; r=jesup
https://hg.mozilla.org/mozilla-central/rev/6ee93495fe0c
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.