Closed Bug 1507140 Opened 3 years ago Closed 3 years ago

Update webrender to dc442bfe38dcd9fc5033d2191b04c6242d167f05 (WR PR #3291)

Categories

(Core :: Graphics: WebRender, enhancement, P3)

65 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: kats, Assigned: nical)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #1507025 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/wrupdater/blob/master/try-latest-webrender.sh
WR @ commit 9ec08a4cf0ce6762a98ddd4df34611dbf0694703 - servo/webrender#3313 - on HG rev dca9c72df68b:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=f485621c308c18f7926d328bb7064d8fadeb046e
WR @ commit 9ec08a4cf0ce6762a98ddd4df34611dbf0694703 - servo/webrender#3313 - on HG rev cbeaa2d94304:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=03669d1ec249bf4252e4541b173ba5a68a6a0ede
Those try pushes are showing more orange than I like to see. The crashtests are failing frequently with bug 1502717, so let's get that fixed before pushing this update.
Depends on: 1502717
WR @ commit 9ec08a4cf0ce6762a98ddd4df34611dbf0694703 - servo/webrender#3313 - on HG rev 0051c8d339a9:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b3b997849f3458b4bf1235517d12ba97d3f9635
WR @ commit 2b64aec136ad778204116080d51743e152580b60 - servo/webrender#3291 - on HG rev 0051c8d339a9:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=65c4b50094a21a9240e236aa892b08ad083a7114
WR @ commit dc442bfe38dcd9fc5033d2191b04c6242d167f05 - servo/webrender#3316 - on HG rev 0051c8d339a9:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2802e13be0060da819e322cd9c7d4cb1c828474
WR @ commit 5609676e166f939fcf1a4141c5b9cb715b68f1d9 - servo/webrender#3315 - on HG rev 0051c8d339a9:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c4473bf21511856c044d509c3d4816bddb18d1d
Move wr::DeviceUint* to wr::DeviceInt*.
Attachment #9025571 - Attachment is obsolete: true
WR @ commit 5609676e166f939fcf1a4141c5b9cb715b68f1d9 - servo/webrender#3315 - on HG rev 4d6d3403eb6b:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed5c5462e96c0611350b59c7b4245c30eae65dcc
Because of comment 3, I'm going to land servo/webrender#3316 first in bug 1502717. This is not the same order in which it landed on the upstream repo, but it cherry-picks cleanly and should give us one autoland push per WR PR and be green all the way.
nical, how did you generate your changes to webrender_ffi_generated.h? When I generate that file I get different results than what you included in your patch. See https://hg.mozilla.org/try/rev/5fb279b45cb1a739ecd6770a26161641c45e2ad4 for example. Is there a euclid bump needed somewhere in this PR?
Flags: needinfo?(nical.bugzilla)
Oh nvm, I realized my problem.
Flags: needinfo?(nical.bugzilla)
WR @ commit 91910a3ce033239fe36ef096223be333ea5df6d7 - servo/webrender#3314 - on HG rev autoland:    https://treeherder.mozilla.org/#/jobs?repo=try&revision=ede608b6c3b20a974c79905b3f84ae2dcb80fff0
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d958c3fea9e6ee0ce0b15625072cc61a8ec0d22 is the try push based on current autoland to WR cset dc442bfe38dcd9fc5033d2191b04c6242d167f05, which is effectively servo/webrender#3291, because I had to land stuff out of order.
Alias: wr-future-update
Assignee: nobody → nical.bugzilla
Summary: Future webrender update bug → Update webrender to dc442bfe38dcd9fc5033d2191b04c6242d167f05 (WR PR #3291)
Move wr::DeviceUint* to wr::DeviceInt*.

Depends on D12149
Attachment #9025715 - Attachment description: Bug 1507140 - Update webrender to commit dc442bfe38dcd9fc5033d2191b04c6242d167f05 (WR PR #3316). r?kats → Bug 1507140 - Update webrender to commit dc442bfe38dcd9fc5033d2191b04c6242d167f05 (WR PR #3291). r?kats
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efa160d5e7d6
Update webrender to commit dc442bfe38dcd9fc5033d2191b04c6242d167f05 (WR PR #3291). r=kats
https://hg.mozilla.org/integration/autoland/rev/59d8473f1764
Gecko changes for WebRender PR #3291. r=kats
Attachment #9025574 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/efa160d5e7d6
https://hg.mozilla.org/mozilla-central/rev/59d8473f1764
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.