Closed Bug 1507186 Opened 4 years ago Closed 4 years ago

Update webapp tests for Python 3

Categories

(Socorro :: Webapp, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

Attachments

(3 files)

We're trying to migrate from Python 2 to Python 3. We've got all the tests in socorro/ passing in Python 3. The next step is to get the webapp tests passing in Python 3.

This bug covers that work.
Making this a P2 and grabbing it to do soon.
Assignee: nobody → willkg
Blocks: 1406703
Status: NEW → ASSIGNED
Priority: -- → P2
Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/f61e6d4428397bede0ddd78383d72da0209b928e
bug 1507186: fix usage of basestring

This fixes usage of basestring across the application and converts uses of
it to six.text_type or six.string_type depending on what's going on.

https://github.com/mozilla-services/socorro/commit/3976891a8c164b96c03767ed68de1999c9e267fd
Merge pull request #4719 from willkg/1507186-basestring

bug 1507186: fix usage of basestring
Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/374a2c0e8e34c733c91cf4350e4855184fb3b7a0
bug 1507186: remove relative imports

This switches all relative imports in the webapp to absolute imports.

https://github.com/mozilla-services/socorro/commit/935ff45f896e65e75732bc35cd63f41685f8ee2d
Merge pull request #4726 from willkg/1507186-relative

bug 1507186: remove relative imports
We're hitting this with loading pyquery which loads lxml:

https://bugs.launchpad.net/lxml/+bug/1732505

They will "release it when they get to it". Meanwhile, we can wrap the imports in a thing that ignores warnings:

    with warnings.catch_warnings():
        warnings.simplefilter('ignore', category=ImportWarning)
        import pyquery

I'll do that.
Depends on: 1511480
No longer depends on: 1511480
All the tests pass in python 3. I'm going to mark this as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.