1507186 - Update webapp tests for Python 3

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We're trying to migrate from Python 2 to Python 3. We've got all the tests in socorro/ passing in Python 3. The next step is to get the webapp tests passing in Python 3.

This bug covers that work.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 and grabbing it to do soon.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4719: bug 1507186: fix usage of basestring

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/f61e6d4428397bede0ddd78383d72da0209b928e
bug 1507186: fix usage of basestring

This fixes usage of basestring across the application and converts uses of
it to six.text_type or six.string_type depending on what's going on.

https://github.com/mozilla-services/socorro/commit/3976891a8c164b96c03767ed68de1999c9e267fd
Merge pull request #4719 from willkg/1507186-basestring

bug 1507186: fix usage of basestring

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4726: bug 1507186: remove relative imports

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/374a2c0e8e34c733c91cf4350e4855184fb3b7a0
bug 1507186: remove relative imports

This switches all relative imports in the webapp to absolute imports.

https://github.com/mozilla-services/socorro/commit/935ff45f896e65e75732bc35cd63f41685f8ee2d
Merge pull request #4726 from willkg/1507186-relative

bug 1507186: remove relative imports

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

We're hitting this with loading pyquery which loads lxml:

https://bugs.launchpad.net/lxml/+bug/1732505

They will "release it when they get to it". Meanwhile, we can wrap the imports in a thing that ignores warnings:

    with warnings.catch_warnings():
        warnings.simplefilter('ignore', category=ImportWarning)
        import pyquery

I'll do that.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4738: bug 1507186: get all the webapp tests passing

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/77accbfa82dfb067d28d35e239e2db0d88e26fe4
bug 1507186: get all the webapp tests passing

https://github.com/mozilla-services/socorro/commit/67e96fb6f5077789d3baa1cfcf4b48fd1399a779
Merge pull request #4738 from willkg/1507186-webapp

bug 1507186: get all the webapp tests passing

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

All the tests pass in python 3. I'm going to mark this as FIXED.