1507233 - Provide more help and/or link to FAQ regarding backouts in improper-author-info error

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement, P1)

Description

[Mark Côté [:mcote]]

Because of bug 1489126, many people are getting the improper-autho-info error: "Diff does not have proper author information in Phabricator.  This can happen if the diff was reated using the web UI, or a non standard client."  Since a frequent source of these errors is from relanding attempts after Phabricator has clobbered the author info, we should provide more help here, until the underlying problem is solved.

Comment 1

[Mark Côté [:mcote]]

This is an easy improvement.

Comment 2

[Israel Madueme [:imadueme]]

This blocker is present on https://lando.devsvcdev.mozaws.net/D474/. You can hover over the 'Blocked' icon to see the message. Can you check that out and determine what the best way to add a longer message/FAQ link is? (Do you want to just tack on FAQ to the end of that blocker message?) The UI is not ideal for long error messages.

Comment 3

[Mark Côté [:mcote]]

The sentence "This can happen if the diff was created using the web UI, or a non standard client." doesn't seem to provide much value on its own (people have been confused by it regardless of the cause).  How about just replacing it with "Please see this FAQ entry."?

Comment 4

[Israel Madueme [:imadueme]]

Attachment: revisions: improve the no author information error message (bug 1507233)

The text in the no author information error message was not really
helpful on it's own; it would need to be much longer to actually
guide the user in fixing the problem. Instead of trying to summarize
things, we simply direct the user to the FAQ and the UI will be able to
link out to the FAQ.

Comment 5

[Israel Madueme [:imadueme]]

Attachment: stack: linkify faq keyword on blocker messages (bug 1507233)

The keyword was linked in the old non-stack UI but we forgot to do
the same on the stack UI.

Comment 6

[Israel Madueme [:imadueme]]

Patches added and I've also updated the FAQ with more accurate help info: https://wiki.mozilla.org/Phabricator/FAQ#Lando_says_.22This_diff_does_not_have_the_proper_author_information_uploaded_to_Phabricator.22.2C_but_I_see_an_author_on_Phabricator._What.27s_wrong.3F.