Closed Bug 1507267 Opened 5 years ago Closed 5 years ago

Enable "about:newtab" page for newly opened tabs

Categories

(Testing :: AWSY, enhancement)

enhancement
Not set
normal

Tracking

(firefox-esr60 fixed, firefox64 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

On bug 1506643 I turned off the usage of `about:newtab` for newly opened tabs for base Marionette tests. As reported on bug 1506643 comment 9 this turned into a lot of unexpected performance improvements. 

Then on comment 12 Bobby Holley clarified that this happened because the performance data is collected by awsy, which itself is built on-top of Marionette. It means that disabling `about:newtab` in Marionette had an impact here, which is not wanted. As such the preference has to be set specifically for those tests.

Now I had a quick look at awsy. The tool is loading the preferences from the following file:

https://dxr.mozilla.org/mozilla-central/source/testing/awsy/conf/prefs.json

Adding `"browser.newtabpage.enabled": true,` there seems to work fine.

Erik or Bob, is that the right place to get this preference added? I see a couple of other file in that folder, so not sure for what those are used for.
Flags: needinfo?(erahm)
Just setting that pref *should* be enough (only in prefs.js, not base-prefs.js, which is used for the about:blank test). We'd need awsy runs to confirm of course.
Flags: needinfo?(erahm)
Locally this looks like it does the right thing.
Bug 1506643 disabled the usage of "about:newtab". But it's
actually needed by awsy for testing the memory consumption
of Firefox.
Eric, does the try push looks good to you? I'm not sure where to check the performance data.
Flags: needinfo?(erahm)
(In reply to Henrik Skupin (:whimboo) from comment #5)
> Eric, does the try push looks good to you? I'm not sure where to check the
> performance data.

I pushed a few retriggers, but the numbers [1] look about what I'd expect (20MB worse for explicit).

[1] https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=fba1bd53e215fc0e7969183bc4365c3a089c29bb&originalSignature=e832acb0cd6ce7001b6d0c4dbb0f38bc6e46f87f&newSignature=e832acb0cd6ce7001b6d0c4dbb0f38bc6e46f87f&framework=4&selectedTimeRange=172800
Flags: needinfo?(erahm)
Great. So I will get this landed once autoland is open again.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1455bc47683
[awsy] Re-enable "about:newtab" page after Bug 1507267. r=erahm
Ionut, please note that this patch reverses the improvements from bug 1506643 so it goes back to the normal memory usage level.
(In reply to Henrik Skupin (:whimboo) from comment #9)
> Ionut, please note that this patch reverses the improvements from bug
> 1506643 so it goes back to the normal memory usage level.

Thanks for the heads up!
https://hg.mozilla.org/mozilla-central/rev/f1455bc47683
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Do we also run awsy tests and evaluate those for beta and esr60? If yes, we should uplift this patch.
Flags: needinfo?(igoldan)
Flags: needinfo?(erahm)
(In reply to Henrik Skupin (:whimboo) from comment #12)
> Do we also run awsy tests and evaluate those for beta and esr60? If yes, we
> should uplift this patch.

We do run AWSY tests for mozilla-beta also. We don't specifically monitor them on ESR60.
Flags: needinfo?(igoldan)
Thanks! As such we should uplift this test-only change to beta then.
Flags: needinfo?(erahm)
Whiteboard: [checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/6430682577bd
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.