1507272 - Enable build telemetry by default for Mozilla employees

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, task)

Description

[(not currently active) Ted Mielczarek]

We discussed this at some point but I can't find that we ever filed a bug, and I didn't get around to this in the initial rollout. We should automatically enable build telemetry for Mozilla employees. The simplest filter here would just be to look at the hg/git username and consider anyone with a @mozilla.com email as an employee.

Comment 1

[Gregory Szorc [:gps]]

I wholeheartedly support this and think running `hg config` or `git config` to look for @mozilla.com is the simplest technical means to identify Mozilla employees. An alternate mechanism would be to look for a network service only available in Mozilla offices. But that obviously won't flag remote employees. There's also the issue that many employees don't commit with their @mozilla.com email. But @mozilla.com is a good start.

While (at least in the USA) employees have minimal privacy protections from their employer, there is certainly legal exposure if we get things wrong and possibly for employees in other jurisdictions. We'll almost certainly want a legal/policy review of whatever we do. In my mind, this is the harder hurdle to clear, since policy decisions impact implementation. And that policy decision may care a lot about false positives.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #1)
> I wholeheartedly support this and think running `hg config` or `git config`
> to look for @mozilla.com is the simplest technical means to identify Mozilla
> employees.

hg config ui.username
git config user.email

> An alternate mechanism would be to look for a network service
> only available in Mozilla offices. But that obviously won't flag remote
> employees. There's also the issue that many employees don't commit with
> their @mozilla.com email. But @mozilla.com is a good start.
> 
> While (at least in the USA) employees have minimal privacy protections from
> their employer, there is certainly legal exposure if we get things wrong and
> possibly for employees in other jurisdictions. We'll almost certainly want a
> legal/policy review of whatever we do. In my mind, this is the harder hurdle
> to clear, since policy decisions impact implementation. And that policy
> decision may care a lot about false positives.

IANAL, but as long as there's a way to opt out, there shouldn't be a legal problem here.

Comment 3

[Kim Moir [:kmoir] ET]

chutten is additional data steward review required to enable build telemetry for Mozilla employees by default?  As mentioned above there is a way to opt out.

Comment 4

[Chris H-C :chutten]

A data collection review[1] would be appropriate. Similar to the one from bug 1291053, but this time mentioning the different population, duration, and that you intend for it to be opt-out instead of opt-in.

[1]: https://wiki.mozilla.org/Firefox/Data_Collection

Comment 5

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Per conversation with :kmoir, I'm going through untriaged bugs in her components and marking the ones which look to be enhancements/tasks with the enhancement severity to get them out of the triage queue.

If this incorrect, please remove the tag.

Comment 6

[Kim Moir [:kmoir] ET]

need to fill this out and send it to our data steward

https://github.com/mozilla/data-review/blob/master/request.md

Comment 7

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1507272: Enable build telemetry for Mozilla devs by default

Comment 8

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1507272: Removes unused parameter in bootstrap function

Depends on D106544

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5629a873f547
Removes unused parameter in bootstrap function r=firefox-build-system-reviewers,glandium

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5629a873f547

Comment 11

[Mitchell Hentges [:mhentges] 🦀]

Forgot to leave-open, my bad.

Comment 12

[Mitchell Hentges [:mhentges] 🦀]

After the above^ patch went live, there was some necessary discussion that took place. To summarize the new telemetry opt-in plan:

• When running each command, we check the user telemetry setting in machrc.
  • If it isn't set, and we haven't done so before, then we detect whether or not the user is an employee (ask Bugzilla, check if VCS email ends in @mozilla.com).
    • If the user is an employee, then enable telemetry. Record the user telemetry setting accordingly.
    • If not, we mark that we attempted auto-employee detection. We leave the user telemetry setting unset.
  • If the user telemetry setting is still unset, we default to not send telemetry.
• When running ./mach bootstrap:
  • After moz-phab has been (optionally) set up, and if the user telemetry setting is not set:
    • Perform the employee detection (from above), even if it's been done before (the moz-phab credentials may provide greater insight).
      • If the user is an employee, enable telemetry.
      • If not, then prompt the user and record their answer. If --no-interactive, don't prompt, leave the telemetry setting unset.

Comment 13

[Mitchell Hentges [:mhentges] 🦀]

Hmm, after refactoring to meet those^ new requirements, I'm finding that the pre-bootstrap check if is_employee status isn't providing any value.
The is_employee check will only work after hg is set up with the user's email, or after they set up moz-phab. The chances of a user doing either of those things without running ./mach bootstrap are relatively low.

I think we should just coalesce this employee opt-in magic back into the bootstrap check, where it previously lived.

Comment 14

[Mike Hommey [:glandium]]

The hg setup in bootstrap doesn't ask to setup the email, though, does it? (even if it does, people may skip vcs-setup in bootstrap)
Same for moz-phab, it's installed, but we're not making it log in, do we?

Comment 15

[Mitchell Hentges [:mhentges] 🦀]

The hg setup in bootstrap doesn't ask to setup the email, though, does it? (even if it does, people may skip vcs-setup in bootstrap)

The vcs-setup part has the users enter their email. It is skippable, yeah.

Same for moz-phab, it's installed, but we're not making it log in, do we?

We conditionally ask if people are submitting patches. If so, we have them log in.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e84d18914fea
Enable build telemetry for Mozilla devs by default r=firefox-build-system-reviewers,glandium

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e84d18914fea

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.