RetainedDisplayListBuilder::AttemptPartialUpdate calls LeavePresShell with an invalid display list

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: mattwoodrow, Assigned: jesup)

Tracking

Trunk
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

LeavePresShell takes an optional displaylist that it uses to check for is non-blank paint (and soon is contentful paint).

When we take the failure early return paths from AttemptPartialUpdate, our current display list is invalid (may contain deleted items from list paint), so we shouldn't be passing it to LeavePresShell to analyze.
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Attachment #9025181 - Flags: review?(matt.woodrow) → review+

Comment 2

5 months ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/73de6b136855
don't pass an invalid list to LeavePresShell on partial updates r=mattwoodrow

Comment 3

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/73de6b136855
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.