Closed
Bug 1507315
Opened 6 years ago
Closed 6 years ago
RetainedDisplayListBuilder::AttemptPartialUpdate calls LeavePresShell with an invalid display list
Categories
(Core :: Web Painting, enhancement, P2)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: jesup)
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
LeavePresShell takes an optional displaylist that it uses to check for is non-blank paint (and soon is contentful paint). When we take the failure early return paths from AttemptPartialUpdate, our current display list is invalid (may contain deleted items from list paint), so we shouldn't be passing it to LeavePresShell to analyze.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9025181 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
|
Reporter | |
Updated•6 years ago
|
Attachment #9025181 -
Flags: review?(matt.woodrow) → review+
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/73de6b136855 don't pass an invalid list to LeavePresShell on partial updates r=mattwoodrow
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/73de6b136855
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•