Closed Bug 1507315 Opened 2 years ago Closed 2 years ago

RetainedDisplayListBuilder::AttemptPartialUpdate calls LeavePresShell with an invalid display list

Categories

(Core :: Web Painting, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mattwoodrow, Assigned: jesup)

Details

Attachments

(1 file)

LeavePresShell takes an optional displaylist that it uses to check for is non-blank paint (and soon is contentful paint).

When we take the failure early return paths from AttemptPartialUpdate, our current display list is invalid (may contain deleted items from list paint), so we shouldn't be passing it to LeavePresShell to analyze.
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Attachment #9025181 - Flags: review?(matt.woodrow) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/73de6b136855
don't pass an invalid list to LeavePresShell on partial updates r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/73de6b136855
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.