Closed Bug 1507325 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 14060 - Add a list of BackgroundFetchRecord objects to

Categories

(Core :: DOM: Service Workers, enhancement, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14060 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14060 Details from upstream follow. Mugdha Lakhani <nator@chromium.org> wrote: > Add a list of BackgroundFetchRecord objects to > > BackgroundFetchRegistration. > > When we allow access to active background fetches, BackgroundFetchRecords for > the fetch can be accessed from multiple places. It simplifies matters if > we return the same record for a request whenever it's accessed. > > This CL adds a (private) list of BackgroundFetchRecords to the > BackgroundFetchRegistration object, and updates it every time match and > matchAll() are called. > > The other change introduced here is to not immediately resolve > responseReady() if the fetch is active and a response for the request > isn't yet available. Once the fetch has completed, or there's a response > available for the request, we resolve pending promises. We also make sure to > return the same promise (resolved or unresolved) for a given record, > every time responseReady is called. > > To keep track of whether there will be further changes to a record, > record_final_ has been introduced. > > For a more detailed discussion, see the following doc: > https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing > > Bug: 875201 > Change-Id: I8cb386efd19086c0993ad2be2fb2691ad90597ec > Reviewed-on: https://chromium-review.googlesource.com/1336151 > WPT-Export-Revision: 201a7f9e36b640843d487e4299a304bb389864fa
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
PR 14060 applied with additional changes from upstream: dcda413dc629781f75684101e9f8ec7d122fa30b
Ran 3 tests and 21 subtests OK : 3 FAIL : 21 New tests that have failures or other problems: /background-fetch/fetch.https.window.html Matching multiple times on the same request works as expected.: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/36b10e4454a8 [wpt PR 14060] - Add a list of BackgroundFetchRecord objects to BackgroundFetchRegistration., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/968beebda7f2 [wpt PR 14060] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/e3467cf419ef [wpt PR 14060] - Add a list of BackgroundFetchRecord objects to BackgroundFetchRegistration., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/edb68a246b56 [wpt PR 14060] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/e3467cf419ef https://hg.mozilla.org/mozilla-central/rev/edb68a246b56
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.