Closed Bug 1507346 Opened 7 years ago Closed 7 years ago

Build system work for a build consuming a pgo profile done in isolation

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1507344

People

(Reporter: chmanchester, Unassigned)

References

Details

This is mostly a matter of setting MOZ_PROFILE_USE and making sure configure can find the merged profile file and point to it in PROFILE_USE_CFLAGS. We should audit checks of MOZ_PROFILE_USE to make sure a clean build will work when this is set. Unlike the current PGO scheme, when we go to do our profile-using build we wont have the remnants of the profile-generate build on the machine to worry about (or benefit from).
I'm not sure what the best way to do this will be, but it might make sense to do the profile data merging in the middle step after running Firefox and then the final build step could just consume that.
(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #1) > I'm not sure what the best way to do this will be, but it might make sense > to do the profile data merging in the middle step after running Firefox and > then the final build step could just consume that. This would be a bit unnatural in a cross-compile because the merge utility is a host binary. We could certainly build it for the target, but it's work.
Good point. I guess we should simply upload the profdata file as an artifact and make the second build step deal with it. (That should mostly be covered by bug 1507344).

Per conversation with :kmoir, I'm going through untriaged bugs in her components and marking the ones which look to be enhancements/tasks with the enhancement severity to get them out of the triage queue.

If this incorrect, please remove the tag.

Severity: normal → enhancement

The relevant pieces for this landed in bug 1507344.

Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.