Closed Bug 1507382 Opened 9 months ago Closed 9 months ago

Private browsing icon is not shown when menu bar is shown

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- unaffected
firefox65 --- fixed

People

(Reporter: bryce, Assigned: mconley)

References

Details

(Keywords: regression)

Attachments

(3 files)

Private browsing windows should display a small purple icon in the upper right to identify themselves as using private browsing. However, if the menu bar is also enabled, this icon is not shown correctly. I have reproduced the issue on Windows and Linux, I suspect it will also affect Mac, but am currently traveling to a conference and do not have a machine to reproduce.

STR:
- Open Firefox with an existing or fresh profile
- Open a private browsing Window
- Ensure the menu bar is toggled off by right clicking the window header and making sure `Menu Bar` is unchecked. In this state you should be able to observe the purple private browsing icon in the upper right of the window.
- Ensure the menu bar is toggled on by right clicking the window header and making sure `Menu Bar` is checked. In this state the private browsing icon should be missing.

Expected Result:
Private browsing icon is present regardless of the menu bar being enabled or not.

Regression range:
This appears to have been regressed by bug 1356920.
ni :mconley based on bug 1356920 looking like the regressing bug.
Flags: needinfo?(mconley)
Component: Private Browsing → Theme
Priority: -- → P1
Thanks, taking.
Assignee: nobody → mconley
Flags: needinfo?(mconley)
See Also: → 1506457
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adab030a385a
Show titlebar items when menubar enabled. r=dao
https://hg.mozilla.org/mozilla-central/rev/adab030a385a
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.