Closed Bug 1507403 Opened 2 years ago Closed 2 years ago

Add more tests for clone before key evaluation

Categories

(Core :: Storage: IndexedDB, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: janv, Assigned: janv)

Details

Attachments

(1 file)

It would be nice to have more tests for this.
There's something in testing/web-platform/tests/IndexedDB/clone-before-keypath-eval.html, but it doesn't cover everything.
Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Attachment #9025282 - Flags: review?(bugmail)
Comment on attachment 9025282 [details] [diff] [review]
patch

Review of attachment 9025282 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but is there any reason not to just add this to the existing or a new WPT test?  Ideally, the only time we would write new non-WPT tests anymore is when internal implementation details are involved or we otherwise need to use testing mechanisms that aren't available to WPT tests at this time.  All of this is happening in content space.

We can just make the WPT changes in our tree and the robot will automatically upstream them for us.
Attachment #9025282 - Flags: review?(bugmail) → review+
Priority: -- → P2
Yeah, I'll file a general meta bug for us to migrate our existing IDB tests that can be migrated to be WPT tests.
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2246038cb41
Add more tests for clone before key evaluation; r=asuth
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ea6c6932f6e
Add more tests for clone before key evaluation; r=asuth
https://hg.mozilla.org/mozilla-central/rev/2ea6c6932f6e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Filed bug 1508202 for the possible test migration.
Flags: needinfo?(jvarga)
You need to log in before you can comment on or make changes to this bug.