1507403 - Add more tests for clone before key evaluation

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement, P2)

Description

[Jan Varga [:janv]]

It would be nice to have more tests for this.
There's something in testing/web-platform/tests/IndexedDB/clone-before-keypath-eval.html, but it doesn't cover everything.

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 9025282 [details] [diff] [review]
patch

Review of attachment 9025282 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but is there any reason not to just add this to the existing or a new WPT test?  Ideally, the only time we would write new non-WPT tests anymore is when internal implementation details are involved or we otherwise need to use testing mechanisms that aren't available to WPT tests at this time.  All of this is happening in content space.

We can just make the WPT changes in our tree and the robot will automatically upstream them for us.

Comment 3

[Jan Varga [:janv]]

Yeah, I'll file a general meta bug for us to migrate our existing IDB tests that can be migrated to be WPT tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2246038cb41
Add more tests for clone before key evaluation; r=asuth

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset a2246038cb41 (Bug 1507403) for ES Lint failure on test_clone_before_key_evaluation.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=212006260&revision=a2246038cb419a2f2765fec76edd2f4bceffb29c

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212006260&repo=mozilla-inbound&lineNumber=248

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/62197abce5c1493d6c404612a889d8db0a331186

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ea6c6932f6e
Add more tests for clone before key evaluation; r=asuth

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2ea6c6932f6e

Comment 8

[Jan Varga [:janv]]

Filed bug 1508202 for the possible test migration.