Closed Bug 1507403 Opened 2 years ago Closed 2 years ago
Add more tests for clone before key evaluation
It would be nice to have more tests for this. There's something in testing/web-platform/tests/IndexedDB/clone-before-keypath-eval.html, but it doesn't cover everything.
Comment on attachment 9025282 [details] [diff] [review] patch Review of attachment 9025282 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but is there any reason not to just add this to the existing or a new WPT test? Ideally, the only time we would write new non-WPT tests anymore is when internal implementation details are involved or we otherwise need to use testing mechanisms that aren't available to WPT tests at this time. All of this is happening in content space. We can just make the WPT changes in our tree and the robot will automatically upstream them for us.
Attachment #9025282 - Flags: review?(bugmail) → review+
Yeah, I'll file a general meta bug for us to migrate our existing IDB tests that can be migrated to be WPT tests.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a2246038cb41 Add more tests for clone before key evaluation; r=asuth
Backed out changeset a2246038cb41 (Bug 1507403) for ES Lint failure on test_clone_before_key_evaluation.js Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=212006260&revision=a2246038cb419a2f2765fec76edd2f4bceffb29c Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212006260&repo=mozilla-inbound&lineNumber=248 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/62197abce5c1493d6c404612a889d8db0a331186
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ea6c6932f6e Add more tests for clone before key evaluation; r=asuth
Filed bug 1508202 for the possible test migration.
You need to log in before you can comment on or make changes to this bug.