Closed Bug 1507421 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 14067 - Fix box-shadow clipping for opaque-background <body>

Categories

(Core :: Layout, enhancement, P4)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14067 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14067
Details from upstream follow.

Florin Malita <fmalita@chromium.org> wrote:
>  Fix box-shadow clipping for opaque-background <body>
>  
>  In the presence of an opaque background,
>  BoxPainterBase::PaintNormalBoxShadow() insets the shadow clip by one
>  unit (in order to mitigate seaming artifacs), effectively expanding the
>  shadow inwards, and relies on the opaque background overdrawing this
>  inset.
>  
>  But \<body> doesn't paint its own background -- it gets transferred to
>  the view and painted in a different context => the shadow inset remains
>  visible.
>  
>  To address this, pass background-skip information to
>  PaintNormalBoxShadow(), and disable the inset logic when the background
>  is not being drawn.
>  
>  Bug: 899342
>  Change-Id: I5e04a1c17c2be324bf4c6767d2159372f546cc24
>  Reviewed-on: https://chromium-review.googlesource.com/1336495
>  WPT-Export-Revision: 9ccb3172923527e230c8c79e875928c4c4d0537b
Component: web-platform-tests → Layout
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d94695f27915
[wpt PR 14067] - Fix box-shadow clipping for opaque-background <body>, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96d50253f05d
[wpt PR 14067] - Fix box-shadow clipping for opaque-background <body>, a=testonly
https://hg.mozilla.org/mozilla-central/rev/96d50253f05d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.