Closed Bug 1507444 Opened 11 months ago Closed 11 months ago

Share button doesnt respect fill opacity on windows

Categories

(Firefox :: Menus, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox64 --- verified
firefox65 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → dharvey
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9aeeae665bd
Add context fill opacity for windows share icon. r=Gijs
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/e9aeeae665bd
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
This issue is verified fixed using Firefox 65.0a1 (BuildId:20181116100115) on Windows 10 64bit.
Status: RESOLVED → VERIFIED
Comment on attachment 9025318 [details]
Bug 1507444 - Add context fill opacity for windows share icon. r=gijs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1363169

User impact if declined: Icon will not look consistent in url bar

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Minor CSS change

String changes made/needed:
Attachment #9025318 - Flags: approval-mozilla-beta?
Comment on attachment 9025318 [details]
Bug 1507444 - Add context fill opacity for windows share icon. r=gijs

small fix for windows "share" button, approved for 64.0b11
Attachment #9025318 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This is verified fixed using Firefox 64.0b11 (provided in comment 7) on Windows 10 64bit.
You need to log in before you can comment on or make changes to this bug.