1507459 - [Remote] The display of the performance panel should solely depend on the value of the configuration on the client side

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Configure 2 different firefox.
2. Launch "server side" firefox using -start-debugger-server. Configure it to use the new performance panel.
3. Launch the "client side" firefox. Make sure it's configured to use the old performance panel.
4. Start WebIDE from the "client side" firefox.
5. Connect to the other firefox (http://localhost:6000)
6. Select a tab.
=> Notice the "performance" panel isn't displayed.

It looks like the configuration value in the server side is taken in to account in the decision to display the performance panel on the client side.

Comment 1

[Julien Wajsberg [:julienw]]

The problem is at [1]: we don't define the actor if the pref is enabled. As a result the code in [2] returns false.
But this pref should solely be a client-side pref, not a server-side pref, so we shouldn't use it in the actor registration file. Actors are lazily loaded.
We did [1] so that the toolbox can do [3] and bail out early if we're using the new performance panel. Instead we should check the pref in [3] because we're on the client side.

[1] https://searchfox.org/mozilla-central/rev/c0b26c40769a1e5607a1ae8be37fe64df64fc55e/devtools/server/actors/utils/actor-registry.js#216-217
[2] https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/devtools/client/definitions.js#259-261
[3] https://searchfox.org/mozilla-central/rev/c0b26c40769a1e5607a1ae8be37fe64df64fc55e/devtools/client/framework/toolbox.js#3027-3029

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1507459 - Register performance actor even if new performance panel is enabled

The server should not be driven by a client-side performance about which perf panel is enabled.
To preserve the behavior, the performance connection will not be initiated by the toolbox if the new perf panel is enabled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/913efd18fce9
Register performance actor even if new performance panel is enabled r=julienw

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/913efd18fce9

Comment 6

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 69.0a1 (2019-06-17) and on Firefox 68.0b11 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.