Closed Bug 1507520 Opened 9 months ago Closed 7 months ago

Make BigInt parsing dependent on run-time feature flag

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1506542 added a feature flag for bigints, and bug 1505849 added parser support.  These developed and landed somewhat concurrently and I forgot to update the parser patch to turn off BigIntLiteral support if the run-time feature flag is off.  This bug is a reminder for me to do that before thinking about turning on the ENABLE_BIGINT compile flag by default.
Summary: Make BigInt parsing → Make BigInt parsing dependent on run-time feature flag
Assignee: nobody → wingo
Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/647e4cfc0eb4
Make BigInt parsing dependent on run-time feature flag r=jandem,terpri

Keywords: checkin-needed
Flags: needinfo?(wingo)
Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f536acca9929
Make BigInt parsing dependent on run-time feature flag r=jandem,terpri

Keywords: checkin-needed
Blocks: 1522436
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.