Closed Bug 1507560 Opened 10 months ago Closed 10 months ago

Android web-platform tests re-initialize mozdevice.ADBAndroid every time a new browser is launched

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

A typical wpt run has multiple browser sessions. Currently, each time a new browser is started, a new ADBAndroid object is created. ADBAndroid initialization is expensive -- reconnecting to the device, querying device properties, establishing root permissions, etc -- so I would prefer to avoid extra ADBAndroid initializations. I hope that reducing that adb traffic will also reduce some of the intermittent adb errors we have seen.
Attachment #9025426 - Flags: review?(wkocher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4977113b1fa2
Avoid extra initializations of ADBAndroid when running Android wpt; r=kwierso
https://hg.mozilla.org/mozilla-central/rev/4977113b1fa2
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.