Closed Bug 1507560 Opened 2 years ago Closed 2 years ago
Android web-platform tests re-initialize mozdevice
.ADBAndroid every time a new browser is launched
A typical wpt run has multiple browser sessions. Currently, each time a new browser is started, a new ADBAndroid object is created. ADBAndroid initialization is expensive -- reconnecting to the device, querying device properties, establishing root permissions, etc -- so I would prefer to avoid extra ADBAndroid initializations. I hope that reducing that adb traffic will also reduce some of the intermittent adb errors we have seen.
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=a39c6415c131001e62d7e7fff1be7bc8e6565843 You can see mozdevice initialized here: https://treeherder.mozilla.org/logviewer.html#?job_id=212011774&repo=try&lineNumber=1158-1165 and then not again for the rest of the test run.
Attachment #9025426 - Flags: review?(wkocher)
Attachment #9025426 - Flags: review?(wkocher) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4977113b1fa2 Avoid extra initializations of ADBAndroid when running Android wpt; r=kwierso
You need to log in before you can comment on or make changes to this bug.