Closed Bug 1507614 Opened Last year Closed Last year

Don't use channel to identify ESR in aboutDialog.js

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox-esr60 64+ fixed
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

In bug 1443771, we added an ESR message to the about dialog but used the channel because there was no other option.

Since bug 1432737 landed, we can use AppConstants.MOZ_APP_VERSION_DISPLAY.

In addition, we can stop hardcoding the version in the about dialog via the build.
Comment on attachment 9025474 [details]
Bug 1507614 - Identify ESR with MOZ_APP_VERSION_DISPLAY.

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Linux Distros that build the ESR are not correctlyl showing Extended Support Release in the about dialog

User impact if declined: Can't identify ESR via about dialog

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 60.1 built with the dependent patch -https://bugzilla.mozilla.org/show_bug.cgi?id=1432737#c10

So we know the correct version will show up.

If you feel the first part (replacing the XUL version) is risky, I can just do a patch that does the esr check for the message and leave the first part alone.

String or UUID changes made by this patch:
Attachment #9025474 - Flags: approval-mozilla-esr60?
Comment on attachment 9025474 [details]
Bug 1507614 - Identify ESR with MOZ_APP_VERSION_DISPLAY.

Let's take this fix, and verify that the version display still works correctly on our own ESR build.
Attachment #9025474 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/9e05a9bac1e5
Identify ESR with MOZ_APP_VERSION_DISPLAY. r=glandium
https://hg.mozilla.org/mozilla-central/rev/9e05a9bac1e5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.