Closed
Bug 1507631
Opened 5 years ago
Closed 5 years ago
Determine whether MOZ_SIGN_CMD handling is still used in the build system
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
I can't find anything that sets MOZ_SIGN_CMD in the tree, and some of the code that handles it seems to have bitrotted in an odd way.
Assignee | ||
Comment 1•5 years ago
|
||
It looks like we'll end up doing the right thing here regardless, but I was looking into this as it relates to bug 1507338.
Per conversation with :kmoir, I'm going through untriaged bugs in her components and marking the ones which look to be enhancements/tasks with the enhancement
severity to get them out of the triage queue.
If this incorrect, please remove the tag.
Severity: normal → enhancement
Comment 3•5 years ago
|
||
I think this should be unused. It definitely isn't used in automation for signing[1], and it seems unlikely it would be used for something else.
[1] signing is handled in a separate task on dedicated workers (https://github.com/mozilla-releng/signingscript)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → cmanchester
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/471d9fab61b3 Remove mentions of MOZ_SIGN_CMD from the build system. r=nalexander
Comment 6•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/f82d110b04f8 Port bug 1507631 - Remove mentions of signing.mk. rs=bustage-fix DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•