add static atoms for all identifiers in user agent style sheets

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
There are a number of dynamic atoms that always get created, since they're found in user agent style sheets.  We should add static atoms for these.  (This is necessary for the bug 1474793 work too, where we can only store static atoms in shared memory.)
Assignee

Updated

6 months ago
Assignee: nobody → cam
Status: NEW → ASSIGNED

Comment 2

6 months ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9135ee87f8d9
Add static atoms for strings in UA style sheets r=njn

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9135ee87f8d9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Do we have a document or static asserts to remind people to add static atoms if they introduce new strings in UA style sheets?
Assignee

Comment 5

6 months ago
There are no assertions currently, but if/when the shared UA style sheets work land, then there will be assertions as part of that.
You need to log in before you can comment on or make changes to this bug.