1507733 - Multiple flex-badges can appear active, even though just a single highlighter is visible on page

Status: VERIFIED FIXED

Description

[Martin Balfanz [:mbalfanz]]

Attachment: multiple-flex-highlighter.mp4

STR:
- visit google.com
- open the inspector and select the search field
- enable any flex highlight through the markup badges
- enable the flex badge for input.gLFyf.gsfi

ER:
- the first badge should turn into an unselect state, only one badge should be active

AR:
- 2 badges are now active

Comment 1

[Martin Balfanz [:mbalfanz]]

When selecting the input field that breaks the badges, I get tons of `JavaScript error: resource://devtools/server/actors/highlighters/flexbox.js, line 311: TypeError: flex is null; can't access its "crossAxisDirection" property` in my terminal

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This error can be triggered simply by flicking the flex badge on Google's input box... taking a quick look as IMO this is embarrassing.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1507733 - Multiple flex-badges can appear active, even though just a single highlighter is visible on page

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Two line fix... asked pbro for review.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9555c7aee866
Multiple flex-badges can appear active, even though just a single highlighter is visible on page r=pbro

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9555c7aee866

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

I reproduced this issue using 65.0a1(2018-11-16), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0b10 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!