Closed
Bug 1507733
Opened 4 years ago
Closed 4 years ago
Multiple flex-badges can appear active, even though just a single highlighter is visible on page
Categories
(DevTools :: Inspector, defect, P2)
Tracking
(firefox65 verified)
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | verified |
People
(Reporter: mbalfanz, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
STR: - visit google.com - open the inspector and select the search field - enable any flex highlight through the markup badges - enable the flex badge for input.gLFyf.gsfi ER: - the first badge should turn into an unselect state, only one badge should be active AR: - 2 badges are now active
Reporter | ||
Comment 1•4 years ago
|
||
When selecting the input field that breaks the badges, I get tons of `JavaScript error: resource://devtools/server/actors/highlighters/flexbox.js, line 311: TypeError: flex is null; can't access its "crossAxisDirection" property` in my terminal
Updated•4 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•4 years ago
|
||
This error can be triggered simply by flicking the flex badge on Google's input box... taking a quick look as IMO this is embarrassing.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Assignee | ||
Updated•4 years ago
|
Priority: P3 → P2
Assignee | ||
Updated•4 years ago
|
OS: Unspecified → All
Hardware: Unspecified → All
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Two line fix... asked pbro for review.
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9555c7aee866 Multiple flex-badges can appear active, even though just a single highlighter is visible on page r=pbro
Comment 6•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9555c7aee866
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Updated•4 years ago
|
Flags: qe-verify+
Comment 7•4 years ago
|
||
I reproduced this issue using 65.0a1(2018-11-16), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0b10 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!
You need to log in
before you can comment on or make changes to this bug.
Description
•