Closed
Bug 1507739
Opened 6 years ago
Closed 6 years ago
XCUITests: Fix testTopSitesOpenInNewPrivateTab due to change in the top sites list
Categories
(Firefox for iOS :: Build & Test, enhancement)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
Details
Attachments
(1 file)
This test testTopSitesOpenInNewPrivateTab is faling on master because now the pre-loaded DB contains one more top site than the list (since the pageControl button has been removed) and so looks like the top sites are randomly placed.
The approach is to select the top site by its name instead of by its position.
Since there will be the posibility to add more rows to the top sites list in the future I would prefer not to modify the DB so that it can be used in the future as it is now.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → irios.mozilla
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9025666 -
Flags: review?(npark)
|
||
Updated•6 years ago
|
Attachment #9025666 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/005c42a9904fa833e9a6db06060486033e9a3ff0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•