1507808 - Bug suggestions always reloaded for specific job

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Open https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=cbeaa2d94304d26f51959067aab7ba74b805634a&selectedJob=212005532 and keep it like this for a minutes.

The failure suggestions will reload and the area showing them flash and render again. This can be reproduced after a reload.

These requests are made every minute:
https://treeherder.mozilla.org/api/jobdetail/?job_guid=19aa6d51-2a10-4dac-9f22-7dde8f2b2330%2F0
https://treeherder.mozilla.org/api/project/mozilla-central/job-log-url/?job_id=212005532
https://treeherder.mozilla.org/api/project/mozilla-central/performance/data/?job_id=212005532
https://treeherder.mozilla.org/api/project/mozilla-central/note/?job_id=212005532
https://treeherder.mozilla.org/api/project/mozilla-central/bug-job-map/?job_id=212005532
https://treeherder.mozilla.org/api/project/mozilla-central/jobs/212005532/bug_suggestions/

Can't reproduce it with https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=cbeaa2d94304d26f51959067aab7ba74b805634a&selectedJob=212014734 which is from the same push.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This bug got filed before this bug report and would be a suggestion: bug 1507658 - related?

Comment 2

[Cameron Dawson [:camd]]

Thanks for the info.  I can reproduce locally.  Working on a solution.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4291

Comment 4

[Cameron Dawson [:camd]]

From the PR:

This was happening because the specific job in question was the newest job on that page.  And we poll for any jobs modified >= the timestamp of the latest job.  So each poll, that job was always returned.  That's not a problem, except that in ``DetailsPanel`` we were checking if we should reload the details panel by object (``oldjob !== newjob``) instead of the values that we care about.  This fixes it so that we just check the things that would change in the job: ``state``, ``result``, ``failure_classification_id``.

So the details will only reload if any of those fields change, which is the correct thing to do.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8ed21676e5f93d4f31737d47ec3aa9cb3e6092d4
Bug 1507808 - Fix job details reloading for specific job (#4291)