Closed
Bug 1507860
Opened 6 years ago
Closed 2 years ago
Use attrs throughout taskgraph.
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(firefox-esr60 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | fixed |
People
(Reporter: tomprince, Assigned: tomprince)
Details
Attachments
(1 file)
attrs is now vendored in tree, but much of the code pre-dates it. We should migrate as much as is sensible to use attrs.
Comment 1•6 years ago
|
||
I strongly approve: attrs is terrific.
Assignee | ||
Comment 2•6 years ago
|
||
This moves most of the low-hanging fruit to use attrs.
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/d1d4e3bf3945 [taskgraph] Move most clases to use attrs; r=dustin
Comment 4•6 years ago
|
||
I'm guessing this change is behind my mysterious try push failures at [1] and [2] (error message: "AttributeError: 'frozenset' object has no attribute 'add'"). Is this expected? [1] https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=213044942&revision=d4394b7d135c7d0189f098fef245455a35c4f009 [2] https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=213044942&revision=877cc6bc12854ace4b08fe3b1b9526356a10b4e0
Flags: needinfo?(mozilla)
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1d4e3bf3945
Backout by mozilla@hocat.ca: https://hg.mozilla.org/mozilla-central/rev/28497e7f30ae Backed out changeset d1d4e3bf3945 for causing decision task failures a=backout
Updated•6 years ago
|
Attachment #9025733 -
Attachment description: Bug 1507860: [taskgraph] Move most clases to use attrs; r?dustin → Bug 1507860: [taskgraph] Move most clases to use attrs; r=dustin
Updated•6 years ago
|
Attachment #9025733 -
Attachment description: Bug 1507860: [taskgraph] Move most clases to use attrs; r=dustin → Bug 1507860: [taskgraph] Move most classes to use attrs; r=dustin
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/00e3e4c617a8 [taskgraph] Move most classes to use attrs; r=dustin
Assignee | ||
Comment 8•6 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4) > I'm guessing this change is behind my mysterious try push failures at [1] > and [2] (error message: "AttributeError: 'frozenset' object has no attribute > 'add'"). Is this expected? It is due to this change, and isn't expected. I've backed out, and relanded with a fix.
Flags: needinfo?(mozilla)
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/00e3e4c617a8
Comment 10•6 years ago
|
||
(In reply to Tom Prince [:tomprince] from comment #8) > It is due to this change, and isn't expected. I've backed out, and relanded > with a fix. Thanks! I've verified that the new version doesn't have the same problem.
Assignee | ||
Comment 11•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/930a7b1001b6
status-firefox-esr60:
--- → fixed
Comment 12•5 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?
Flags: needinfo?(mozilla)
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(mozilla)
Comment 13•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?
Flags: needinfo?(mozilla)
Comment 14•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?
Flags: needinfo?(mozilla)
Comment 15•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:ahal, maybe it's time to close this bug?
Flags: needinfo?(ahal)
Comment 16•2 years ago
|
||
There's likely still work to be done here, but we're also talking about deprecating 3.6 and/or vendoring the dataclasses backport. So I'm going to resolve for now and we can file a new bug when / if the need arises.. though this will likely never be prioritized.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mozilla)
Flags: needinfo?(ahal)
Resolution: --- → FIXED
Updated•2 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•