Status

task
ASSIGNED
6 months ago
5 months ago

People

(Reporter: tomprince, Assigned: tomprince)

Tracking

({leave-open})

unspecified

Firefox Tracking Flags

(firefox-esr60 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
attrs is now vendored in tree, but much of the code pre-dates it. We should migrate as much as is sensible to use attrs.
I strongly approve: attrs is terrific.
Assignee

Comment 2

6 months ago
This moves most of the low-hanging fruit to use attrs.

Comment 3

6 months ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/d1d4e3bf3945
[taskgraph] Move most clases to use attrs; r=dustin
I'm guessing this change is behind my mysterious try push failures at [1] and [2] (error message: "AttributeError: 'frozenset' object has no attribute 'add'"). Is this expected?

[1] https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=213044942&revision=d4394b7d135c7d0189f098fef245455a35c4f009
[2] https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=213044942&revision=877cc6bc12854ace4b08fe3b1b9526356a10b4e0
Flags: needinfo?(mozilla)

Comment 6

6 months ago
Backout by mozilla@hocat.ca:
https://hg.mozilla.org/mozilla-central/rev/28497e7f30ae
Backed out changeset d1d4e3bf3945 for causing decision task failures a=backout
Attachment #9025733 - Attachment description: Bug 1507860: [taskgraph] Move most clases to use attrs; r?dustin → Bug 1507860: [taskgraph] Move most clases to use attrs; r=dustin
Attachment #9025733 - Attachment description: Bug 1507860: [taskgraph] Move most clases to use attrs; r=dustin → Bug 1507860: [taskgraph] Move most classes to use attrs; r=dustin

Comment 7

6 months ago
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/00e3e4c617a8
[taskgraph] Move most classes to use attrs; r=dustin
Assignee

Comment 8

6 months ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> I'm guessing this change is behind my mysterious try push failures at [1]
> and [2] (error message: "AttributeError: 'frozenset' object has no attribute
> 'add'"). Is this expected?

It is due to this change, and isn't expected. I've backed out, and relanded with a fix.
Flags: needinfo?(mozilla)
(In reply to Tom Prince [:tomprince] from comment #8)
> It is due to this change, and isn't expected. I've backed out, and relanded
> with a fix.

Thanks! I've verified that the new version doesn't have the same problem.
You need to log in before you can comment on or make changes to this bug.