1507860 - Use attrs throughout taskgraph.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Tom Prince [:tomprince]]

attrs is now vendored in tree, but much of the code pre-dates it. We should migrate as much as is sensible to use attrs.

Comment 1

[Gregory Szorc [:gps]]

I strongly approve: attrs is terrific.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1507860: [taskgraph] Move most classes to use attrs; r=dustin

This moves most of the low-hanging fruit to use attrs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1d4e3bf3945
[taskgraph] Move most clases to use attrs; r=dustin

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I'm guessing this change is behind my mysterious try push failures at [1] and [2] (error message: "AttributeError: 'frozenset' object has no attribute 'add'"). Is this expected?

[1] https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=213044942&revision=d4394b7d135c7d0189f098fef245455a35c4f009
[2] https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=213044942&revision=877cc6bc12854ace4b08fe3b1b9526356a10b4e0

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d1d4e3bf3945

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/28497e7f30ae
Backed out changeset d1d4e3bf3945 for causing decision task failures a=backout

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e3e4c617a8
[taskgraph] Move most classes to use attrs; r=dustin

Comment 8

[Tom Prince [:tomprince]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #4)
> I'm guessing this change is behind my mysterious try push failures at [1]
> and [2] (error message: "AttributeError: 'frozenset' object has no attribute
> 'add'"). Is this expected?

It is due to this change, and isn't expected. I've backed out, and relanded with a fix.

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/00e3e4c617a8

Comment 10

[Kartikaya Gupta (email:[e-mail])]

(In reply to Tom Prince [:tomprince] from comment #8)
> It is due to this change, and isn't expected. I've backed out, and relanded
> with a fix.

Thanks! I've verified that the new version doesn't have the same problem.

Comment 11

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/930a7b1001b6

Comment 12

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?

Comment 13

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?

Comment 14

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?

Comment 15

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:ahal, maybe it's time to close this bug?

Comment 16

[Andrew Halberstadt [:ahal]]

There's likely still work to be done here, but we're also talking about deprecating 3.6 and/or vendoring the dataclasses backport. So I'm going to resolve for now and we can file a new bug when / if the need arises.. though this will likely never be prioritized.