Add print accessibly subtree to JSON functionality to the a11y panel.

RESOLVED FIXED in Firefox 65

Status

enhancement
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

({dev-doc-needed})

unspecified
Firefox 65
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(7 attachments)

Assignee

Description

6 months ago
This is something users were interested in.

Also this is something that might come useful when we are going to work on a11y issue site reporting.
Assignee

Comment 1

6 months ago
Hi Victoria, I was wondering if there are any concerns or any suggestions with adding this feature.

The way it works - right click on any of the accessible object rows in the a11y tree and click on Print to JSON.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5c26a8b1c44c5b4b69e5225399360b89d4c8318
Flags: needinfo?(victoria)
Assignee

Comment 2

6 months ago
MozReview-Commit-ID: HhoNsCAiZAk
Assignee

Comment 3

6 months ago
MozReview-Commit-ID: JdZe0N3ot4c

Depends on D12501
Assignee

Comment 4

6 months ago
MozReview-Commit-ID: EhVlhvjDyS8

Depends on D12502
Assignee

Comment 5

6 months ago
MozReview-Commit-ID: HyqYgHCCp3T

Depends on D12503
Assignee

Comment 7

6 months ago
Attachment #9026607 - Flags: review?(chutten)
Attachment #9026600 - Attachment description: Bug 1507870 - add telemetry for accessibility panel tree context menu functionality. r?pbro,francois, data-review=francois → Bug 1507870 - add telemetry for accessibility panel tree context menu functionality. r?pbro,chutten, data-review=chutten

Comment 8

6 months ago
Comment on attachment 9026607 [details]
Request for data collection review form.

Preliminary notes:

  Please include an explanation of what "context menu id" means in this context. Is it a global ID? Or is it more like a category or label? Is it a number? What space of values do you plan to collect in this key?

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This is Telemetry so it will show in the definition file Scalars.yaml, the Probe Dictionary, and on the telemetry.mozilla.org Measurement dashboard.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This is Telemetry so the user can opt-out via about:preferences#privacy.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, expires in Firefox 70.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on, all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Yes. See note above.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes, so long as the identifiers are confirmed to be categories/labels.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :yzen is responsible for renewing or removing this probe before it expires in Firefox 70.

---
Result: datareview+ pending clarification on "context menu id"
Flags: needinfo?(yzenevich)

Updated

6 months ago
Attachment #9026607 - Flags: review?(chutten) → review+
Assignee

Comment 9

6 months ago
(In reply to Chris H-C :chutten from comment #8)
> Comment on attachment 9026607 [details]
> Request for data collection review form.
> 
> Preliminary notes:
> 
>   Please include an explanation of what "context menu id" means in this
> context. Is it a global ID? Or is it more like a category or label? Is it a
> number? What space of values do you plan to collect in this key?

Yes, to clarify this is more of a label/category, for example right now we only have one - "print-to-json" , future ones that are planned are "report-site-a11y-issue"
Flags: needinfo?(yzenevich)
Assignee

Comment 10

6 months ago
Patrick, if you have a moment, could you see my comment in https://phabricator.services.mozilla.com/D12503 regarding introducing form for accessibility actor? thanks!
Flags: needinfo?(pbrosset)
Done! Sorry about the delay. Feel free to @ me on phabricator next times so I don't forget.
Flags: needinfo?(pbrosset)
Attachment #9026598 - Attachment description: Bug 1507870 - add supports() method to the top level a11y actor that returns serverside capabilities. r?pbro → Bug 1507870 - add checks for whether Accessible actor has snapshot capability. r?pbro
Attachment #9026600 - Attachment description: Bug 1507870 - add telemetry for accessibility panel tree context menu functionality. r?pbro,chutten, data-review=chutten → Bug 1507870 - add telemetry for accessibility panel tree context menu functionality. r?pbro,janerik, data-review=chutten
Assignee

Comment 12

6 months ago
Adding screen cast instead of just ni?
Flags: needinfo?(victoria)
Attachment #9027989 - Flags: ui-review?(victoria)
Attachment #9026600 - Attachment description: Bug 1507870 - add telemetry for accessibility panel tree context menu functionality. r?pbro,janerik, data-review=chutten → Bug 1507870 - add telemetry for accessibility panel tree context menu functionality. r?janerik, data-review=chutten
Comment on attachment 9027989 [details]
Screencast of Print to JSON

Looks great! One tiny thing - "to" in Print To JSON" should be lowercase. There could be a separate text style patch.
Attachment #9027989 - Flags: ui-review?(victoria) → ui-review+
Assignee

Comment 14

6 months ago
(In reply to Victoria Wang [:victoria] from comment #13)
> Comment on attachment 9027989 [details]
> Screencast of Print to JSON
> 
> Looks great! One tiny thing - "to" in Print To JSON" should be lowercase.
> There could be a separate text style patch.

will fix! Thanks

Comment 15

6 months ago
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7b2786f18743
add support for contextmenu extensibility of TreeRow. r=Honza
https://hg.mozilla.org/integration/autoland/rev/aa273e203681
add support for taking a snapshot of the subtree of the accessible object. r=pbro
https://hg.mozilla.org/integration/autoland/rev/5056bbebdb71
add checks for whether Accessible actor has snapshot capability. r=pbro
https://hg.mozilla.org/integration/autoland/rev/e226f18cbdff
add Print to JSON functionality to the a11y inspector. r=pbro
https://hg.mozilla.org/integration/autoland/rev/0ffc19c364e8
add telemetry for accessibility panel tree context menu functionality. r=janerik, data-review=chutten
Assignee

Updated

4 months ago
Keywords: dev-doc-needed
Depends on: 1520107
You need to log in before you can comment on or make changes to this bug.