Port bug 1507640: Remove about:support "Show update history" button when the updater is disabled

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

With a build without updater enabled clicking the "Show update history" results in TypeError: Cc['@mozilla.org/updates/update-prompt;1'] is undefined
Posted patch 1507874-aboutSupport.patch (obsolete) — Splinter Review
Port of https://hg.mozilla.org/mozilla-central/rev/bfa775531d0d

It looks like more changes because I fixed the indentation too.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9025748 - Flags: review?(jorgk)
I've sync-ed the file with the toolkit version some more. Please do a diff with the version in toolkit/content.
Attachment #9025748 - Attachment is obsolete: true
Attachment #9025748 - Flags: review?(jorgk)
Attachment #9025874 - Flags: review+
Attachment #9025874 - Flags: feedback?(richard.marti)
Oops, missing closing brace.
Attachment #9025874 - Attachment is obsolete: true
Attachment #9025874 - Flags: feedback?(richard.marti)
Attachment #9025875 - Flags: review+
Attachment #9025875 - Flags: feedback?(richard.marti)
Comment on attachment 9025875 [details] [diff] [review]
1507874-aboutSupport.patch (JK, v1b)

Puh, it didn't rot my next aboutSupport patch (Convert about:support to Fluent) in my queue. :-)
Attachment #9025875 - Flags: feedback?(richard.marti) → feedback+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/062d7a8d50be
Port bug 1507640: Remove about:support "Show update history" button when the updater is disabled. r=jorgk CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.