Closed
Bug 1507913
Opened 5 years ago
Closed 5 years ago
Crash in java.lang.NullPointerException: at android.view.ViewRootImpl.findFocusedVirtualNode(ViewRootImpl.java)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(geckoview64 fixed, firefox63 unaffected, firefox64+ fixed, firefox65+ fixed)
RESOLVED
FIXED
Firefox 65
People
(Reporter: marcia, Assigned: eeejay)
References
Details
(Keywords: crash, regression, Whiteboard: [geckoview:p1])
Crash Data
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
This bug was filed from the Socorro interface and is report bp-1b6e7917-ba3e-4d53-a8e5-6ce6f0181116. ============================================================= Seen while looking at nightly crash data: https://bit.ly/2KbUqXS. Crashes started using Build ID 20181115100056. 14 crashes/8 installs so far. Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=073045259e75e0c8f7b8ffcd5e4bf72570f98f3e&tochange=dca9c72df68bb59692118595dea65b78cde5b371 Maybe Bug 1507026? Just a guess since the stack has some accessibility stuff in it. ni on :eeejay Java stack trace: java.lang.NullPointerException at android.view.ViewRootImpl.findFocusedVirtualNode(ViewRootImpl.java:2865) at android.view.ViewRootImpl.fireAccessibilityFocusEventIfHasFocusedNode(ViewRootImpl.java:2828) at android.view.ViewRootImpl.handleWindowFocusChanged(ViewRootImpl.java:2806) at android.view.ViewRootImpl.access$900(ViewRootImpl.java:139) at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:4396) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6863) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:537) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Flags: needinfo?(eitan)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → eitan
Flags: needinfo?(eitan)
Assignee | ||
Comment 1•5 years ago
|
||
We should never return null nodes from createAccessibilityNodeInfo. Returning orphaned nodes is not an option either because TalkBack and other ATs go berserk when they can't walk up the tree. We should return the root node when we fail to return a virtual one.
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b5790baa26c Return root a11y node when failing to retrieve virtual child. r=snorp
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b5790baa26c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 5•5 years ago
|
||
This is one of a number of a11y fixes being tracked for uplift to 64.
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9026182 [details] Bug 1507913 - Return root a11y node when failing to retrieve virtual child. r?snorp! [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1506709 User impact if declined: Occasional crashes. Most notably when bringing up Google Assistant. Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): This is a simple patch, I think it can be applied cleanly to beta now with no dependencies. String changes made/needed:
Attachment #9026182 -
Flags: approval-mozilla-beta?
Comment 7•5 years ago
|
||
Adding the [geckoview:p1] whiteboard tag so the GV team can track this fix for the Focus 8.0 Beta test.
Whiteboard: [geckoview:p1]
Comment 8•5 years ago
|
||
Comment on attachment 9026182 [details] Bug 1507913 - Return root a11y node when failing to retrieve virtual child. r?snorp! crash fix for another change going into beta, approved for 64.0b12
Attachment #9026182 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/ca44d60ac671
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•