made ownership of MetadataTags more clear in the ogg code

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P3
normal
Rank:
25
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Use UniquePtr for return types, so it's obvious who has ownership.
I'm in here for other reasons, and this bugged me, so...
Attachment #9025771 - Flags: review?(gsquelart)
Comment on attachment 9025771 [details] [diff] [review]
made ownership of MetadataTags more clear in the ogg code

LGTM, but officially I'm not in media playback anymore.
Forwarding r? to jya, so he knows about this.
Attachment #9025771 - Flags: review?(gsquelart) → review?(jyavenard)
Rank: 25
Component: Audio/Video → Audio/Video: Playback
Priority: -- → P3
Comment on attachment 9025771 [details] [diff] [review]
made ownership of MetadataTags more clear in the ogg code

Review of attachment 9025771 [details] [diff] [review]:
-----------------------------------------------------------------

thank you for this. Long overdue

::: dom/media/MediaMetadataManager.h
@@ +47,4 @@
>    // The media info, including the info of audio tracks and video tracks.
>    // The ownership is transfered to MediaDecoder when dispatching to the
>    // main thread.
>    nsAutoPtr<MediaInfo> mInfo;

should be replacing that too.

I believe we have a bug somewhere to replace all nsAutoPtr with UniquePtr
Attachment #9025771 - Flags: review?(jyavenard) → review+
(In reply to Jean-Yves Avenard [:jya] from comment #3)
> ::: dom/media/MediaMetadataManager.h
> @@ +47,4 @@
> >    // The media info, including the info of audio tracks and video tracks.
> >    // The ownership is transfered to MediaDecoder when dispatching to the
> >    // main thread.
> >    nsAutoPtr<MediaInfo> mInfo;
> 
> should be replacing that too.
> 
> I believe we have a bug somewhere to replace all nsAutoPtr with UniquePtr

We do, and I'm sure I'll be along with more reviews at some point. :)
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce4515855b43
make ownership of MetadataTags more clear in the ogg code; r=gerald,jya
https://hg.mozilla.org/mozilla-central/rev/ce4515855b43
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.