Closed Bug 1507924 Opened 1 year ago Closed 1 year ago

Remove codemirror/old-debugger.css and related assets

Categories

(DevTools :: Debugger, enhancement)

enhancement
Not set

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

Details

Attachments

(1 file)

Tim Nguyen in https://bugzilla.mozilla.org/show_bug.cgi?id=1314057#c59:

> Please don't forget to remove the old debugger images and related CSS as well:
> devtools/client/themes/images/debugger-step-in.svg
> devtools/client/themes/images/debugger-step-out.svg
> devtools/client/themes/images/debugger-step-over.png
> devtools/client/themes/images/debugger-step-over.svg
> devtools/client/themes/images/debugger-step-over@2x.png
> devtools/client/themes/images/debugger-toggleBreakpoints.svg 
> devtools/client/themes/images/breakpoint.svg
> devtools/client/themes/debugger.css
> devtools/client/sourceeditor/codemirror/old-debugger.css

It seems no follow-up bug was created for these, so here goes.

We can also remove:
devtools/client/themes/images/editor-error.png
A few were already gone.

Made a patch to remove:
- devtools/client/sourceeditor/codemirror/old-debugger.css
- devtools/client/themes/images/breakpoint.svg
- devtools/client/themes/images/editor-error.png

And instead of removing the debugger-step-*.svg and pointing to images from the new debugger, knowing that A) those images could change without anybody noticing the breakage in the Canvas debugger and B) I couldn't actually make the Canvas debugger work to look at these icons, I've decided to rename them to canvasdebugger-step-*.svg.

That way, if we remove or overhaul the canvas debugger, it will be easier to spot that we might need to do something with those images (e.g. remove them).
Assignee: nobody → florens
Status: NEW → ASSIGNED
Not pushing to TRY right now, I'll wait for the orange situation (bug 1507781 it seems) to stabilize.
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/ba69286f9c33
Remove codemirror/old-debugger.css and related assets; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/ba69286f9c33
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.