Closed Bug 1507924 Opened 1 year ago Closed 1 year ago
.css and related assets
47 bytes, text/x-phabricator-request
|Details | Review|
Tim Nguyen in https://bugzilla.mozilla.org/show_bug.cgi?id=1314057#c59: > Please don't forget to remove the old debugger images and related CSS as well: > devtools/client/themes/images/debugger-step-in.svg > devtools/client/themes/images/debugger-step-out.svg > devtools/client/themes/images/debugger-step-over.png > devtools/client/themes/images/debugger-step-over.svg > email@example.com > devtools/client/themes/images/debugger-toggleBreakpoints.svg > devtools/client/themes/images/breakpoint.svg > devtools/client/themes/debugger.css > devtools/client/sourceeditor/codemirror/old-debugger.css It seems no follow-up bug was created for these, so here goes. We can also remove: devtools/client/themes/images/editor-error.png
A few were already gone. Made a patch to remove: - devtools/client/sourceeditor/codemirror/old-debugger.css - devtools/client/themes/images/breakpoint.svg - devtools/client/themes/images/editor-error.png And instead of removing the debugger-step-*.svg and pointing to images from the new debugger, knowing that A) those images could change without anybody noticing the breakage in the Canvas debugger and B) I couldn't actually make the Canvas debugger work to look at these icons, I've decided to rename them to canvasdebugger-step-*.svg. That way, if we remove or overhaul the canvas debugger, it will be easier to spot that we might need to do something with those images (e.g. remove them).
Assignee: nobody → florens
Status: NEW → ASSIGNED
Not pushing to TRY right now, I'll wait for the orange situation (bug 1507781 it seems) to stabilize.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ba69286f9c33 Remove codemirror/old-debugger.css and related assets; r=jdescottes
You need to log in before you can comment on or make changes to this bug.