1507947 - IllegalArgumentException: Service not registered: org.mozilla.gecko.process.GeckoProcessManager$ChildConnection@f3bf8d0

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Chris Peterson [:cpeterson]]

There has been one instance of this crash signature from a Focus 8.0 Nightly user with GV 64 Beta.

This bug was filed from the Socorro interface and is
report bp-c227ee6b-7050-4182-a3b4-6478f0181116.
=============================================================

Java stack trace:

java.lang.IllegalArgumentException: Service not registered: org.mozilla.gecko.process.GeckoProcessManager$ChildConnection@f3bf8d0
	at android.app.LoadedApk.forgetServiceDispatcher(LoadedApk.java:1517)
	at android.app.ContextImpl.unbindService(ContextImpl.java:1639)
	at android.content.ContextWrapper.unbindService(ContextWrapper.java:698)
	at org.mozilla.gecko.process.GeckoProcessManager$ChildConnection.bind(GeckoProcessManager.java:85)
	at org.mozilla.gecko.process.GeckoProcessManager.start(GeckoProcessManager.java:201)
	at org.mozilla.gecko.process.GeckoProcessManager.start(GeckoProcessManager.java:189)

Comment 1

[Chris Peterson [:cpeterson]]

P1 because this is GV top crash #3.

Comment 2

[Chris Peterson [:cpeterson]]

In anticipation of the creation of the GECKOVIEW_64_RELBRANCH next week, I am moving this bug from status-firefox64=affected to status-geckoview64=affected.

Comment 3

[Chris Peterson [:cpeterson]]

James, do you have any updates on this LoadedApk.forgetServiceDispatcher crash? It's GV top crash #2 for Focus 8.0 beta.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1507947 - Be more careful when unbinding child process services

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Whoops, had forgotten to put my patch up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7b73b7ab1a5
Be more careful when unbinding child process services r=geckoview-reviewers,esawin

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out changeset d7b73b7ab1a5 (Bug 1507947) for mochitest failures on test_expanding_selection_per_page.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/a80e4d4824f38ec775a464c05dcf0c853fc2fa26

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=d7b73b7ab1a5edd198b4851eb577331af6e73464&selectedJob=216278924

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216278924&repo=autoland&lineNumber=1712

Comment 8

[Cristian Brindusan [:cbrindusan]]

There are also mochitest crashes failures on layout/base/tests/test_event_target_iframe_oop.html | application crashed [@ mozilla::ipc::GeckoChildProcessHost::OpenPrivilegedHandle(int)].
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216276271&repo=autoland&lineNumber=1580

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52c382554814
Be more careful when unbinding child process services r=geckoview-reviewers,esawin

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/52c382554814

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9030235 [details]
Bug 1507947 - Be more careful when unbinding child process services

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: Crashes when using GeckoView

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): This change affects how we manage child processes on Android, which is a critical path. It seems to work, though, as we have a bunch of tests that exercise this path.

String changes made/needed: None

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9030235 [details]
Bug 1507947 - Be more careful when unbinding child process services

[GeckoView Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for consideration: 

User impact if declined: 

Fix Landed on Version: 

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 

String or UUID changes made by this patch:

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

I guess I really wanted approval-mozilla-geckoview64 instead of approval-mozilla-beta

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030235 [details]
Bug 1507947 - Be more careful when unbinding child process services

[Triage Comment]
Fixes a GeckoView crash. Approved for 65.0b5 and GV64.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5f982689c71

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/448b0b631dd99e6e27559598c1cc191d4cbf10f7

Comment 17

[Sorina Florean [:sflorean]]

Tested on Firefox Focus 8.0.4 and the issue is still reproducible but seems that the fix is not landed yet. We saw the same issue in GitHub and is not fixed. We'll keep an eye and check again when the Focus is with the patch.

Comment 18

[Sorina Florean [:sflorean]]

(In reply to Sorina Florean [:sorina] from comment #17)
> Tested on Firefox Focus 8.0.4 and the issue is still reproducible but seems
> that the fix is not landed yet. We saw the same issue in GitHub and is not
> fixed. We'll keep an eye and check again when the Focus is with the patch.

Sorry, wrong bug number.