Port bug 1502457 and remove THUNDERBIRD_VERSION and use MOZ_APP_VERSION in python configure

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks 1 bug)

unspecified
Thunderbird 65.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

FX removed the version defines in browser and moved the to the python configure.
Should we follow?
Rob, I ported all that was changed in /browser in bug 1502457.

Try build https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=eaef115d82ccb5015107456ce529c1bca2d85744
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9025796 - Flags: review?(rob)
Note that bug 1502457 was backed out.
Blocks: 1502457
Comment on attachment 9025796 [details] [diff] [review]
1507948-MOZ_APP_VERSION.patch

This looks good. Thanks.
I tested with the mentioned backout as well; it doesn't seem to have an effect either way. I'm all in favor of moving stuff out of confvars.sh.
Attachment #9025796 - Flags: review?(rob) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cd6d89475b76
Port bug 1502457 and remove THUNDERBIRD_VERSION and use MOZ_APP_VERSION in python configure. r=rjl
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.